* [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
@ 2018-01-02 14:34 Colin King
2018-01-03 8:38 ` Antoine Tenart
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-01-02 14:34 UTC (permalink / raw)
To: Antoine Tenart, Herbert Xu, David S . Miller, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function safexcel_try_push_requests is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'safexcel_try_push_requests' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/crypto/inside-secure/safexcel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 0d685be75241..e3745139644b 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -432,8 +432,8 @@ static int safexcel_hw_init(struct safexcel_crypto_priv *priv)
}
/* Called with ring's lock taken */
-int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring,
- int reqs)
+static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv,
+ int ring, int reqs)
{
int coal = min_t(int, reqs, EIP197_MAX_BATCH_SZ);
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static
2018-01-02 14:34 [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static Colin King
@ 2018-01-03 8:38 ` Antoine Tenart
0 siblings, 0 replies; 2+ messages in thread
From: Antoine Tenart @ 2018-01-03 8:38 UTC (permalink / raw)
To: Colin King
Cc: Antoine Tenart, Herbert Xu, David S . Miller, linux-crypto,
kernel-janitors, linux-kernel
Hi Colin,
On Tue, Jan 02, 2018 at 02:34:10PM +0000, Colin King wrote:
>
> /* Called with ring's lock taken */
> -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring,
> - int reqs)
> +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv,
> + int ring, int reqs)
Alignment should match open parenthesis, one space is missing. Otherwise,
looks good to me.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-03 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 14:34 [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static Colin King
2018-01-03 8:38 ` Antoine Tenart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox