* [PATCH] crypto: ux500 - fix license comment syntax error
@ 2019-06-01 14:49 Alex Xu (Hello71)
2019-06-01 16:28 ` Greg KH
2019-06-01 16:29 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Alex Xu (Hello71) @ 2019-06-01 14:49 UTC (permalink / raw)
To: linux-kernel, linux-crypto, tglx
Cc: allison, alexios.zavras, swinslow, rfontana, gregkh, linux-spdx,
torvalds, Alex Xu (Hello71)
Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
separator. Stop.
Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with
SPDX - rule 194")
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---
drivers/crypto/ux500/cryp/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ux500/cryp/Makefile b/drivers/crypto/ux500/cryp/Makefile
index a90b50597e5c..3e67531f484c 100644
--- a/drivers/crypto/ux500/cryp/Makefile
+++ b/drivers/crypto/ux500/cryp/Makefile
@@ -2,7 +2,7 @@
#/*
# * Copyright (C) ST-Ericsson SA 2010
# * Author: shujuan.chen@stericsson.com for ST-Ericsson.
- */
+# */
ccflags-$(CONFIG_CRYPTO_DEV_UX500_DEBUG) += -DDEBUG
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: ux500 - fix license comment syntax error
2019-06-01 14:49 [PATCH] crypto: ux500 - fix license comment syntax error Alex Xu (Hello71)
@ 2019-06-01 16:28 ` Greg KH
2019-06-01 16:29 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-06-01 16:28 UTC (permalink / raw)
To: Alex Xu (Hello71)
Cc: linux-kernel, linux-crypto, tglx, allison, alexios.zavras,
swinslow, rfontana, linux-spdx, torvalds
On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> separator. Stop.
>
> Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with
> SPDX - rule 194")
>
> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> ---
> drivers/crypto/ux500/cryp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ugh, sorry about that. Will go queue that up right now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: ux500 - fix license comment syntax error
2019-06-01 14:49 [PATCH] crypto: ux500 - fix license comment syntax error Alex Xu (Hello71)
2019-06-01 16:28 ` Greg KH
@ 2019-06-01 16:29 ` Greg KH
2019-06-01 19:41 ` Alex Xu
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-06-01 16:29 UTC (permalink / raw)
To: Alex Xu (Hello71)
Cc: linux-kernel, linux-crypto, tglx, allison, alexios.zavras,
swinslow, rfontana, linux-spdx, torvalds
On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> separator. Stop.
>
> Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> ---
> drivers/crypto/ux500/cryp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Also, how did 0-day not catch this? Is this an odd configuration that
it can not build?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: ux500 - fix license comment syntax error
2019-06-01 16:29 ` Greg KH
@ 2019-06-01 19:41 ` Alex Xu
2019-06-02 0:37 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Alex Xu @ 2019-06-01 19:41 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, linux-crypto, tglx, allison, alexios.zavras,
swinslow, rfontana, linux-spdx, torvalds
Quoting Greg KH (2019-06-01 16:29:07)
> On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> > separator. Stop.
> >
> > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> > ---
> > drivers/crypto/ux500/cryp/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Also, how did 0-day not catch this? Is this an odd configuration that
> it can not build?
I had to run "make clean" to get the error.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: ux500 - fix license comment syntax error
2019-06-01 19:41 ` Alex Xu
@ 2019-06-02 0:37 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-06-02 0:37 UTC (permalink / raw)
To: Alex Xu
Cc: Greg KH, Linux Kernel Mailing List, linux-crypto, Thomas Gleixner,
allison, alexios.zavras, swinslow, rfontana, linux-spdx,
Linus Torvalds
On Sun, Jun 2, 2019 at 4:41 AM Alex Xu <alex_y_xu@yahoo.ca> wrote:
>
> Quoting Greg KH (2019-06-01 16:29:07)
> > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> > > separator. Stop.
> > >
> > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> > > ---
> > > drivers/crypto/ux500/cryp/Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Also, how did 0-day not catch this? Is this an odd configuration that
> > it can not build?
>
> I had to run "make clean" to get the error.
I think this copyright block is ugly.
# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) ST-Ericsson SA 2010
# Author: shujuan.chen@stericsson.com for ST-Ericsson.
looks nicer IMHO.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-02 0:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-01 14:49 [PATCH] crypto: ux500 - fix license comment syntax error Alex Xu (Hello71)
2019-06-01 16:28 ` Greg KH
2019-06-01 16:29 ` Greg KH
2019-06-01 19:41 ` Alex Xu
2019-06-02 0:37 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox