* [PATCH] Crypto: fixed a comment coding style issue
@ 2019-06-23 1:40 Aditya Parekh
2019-06-24 4:07 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Parekh @ 2019-06-23 1:40 UTC (permalink / raw)
To: herbert; +Cc: davem, trivial, linux-crypto, Aditya Parekh
Fixed a coding style issue.
Signed-off-by: Aditya Parekh <kerneladi@gmail.com>
---
crypto/fcrypt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/crypto/fcrypt.c b/crypto/fcrypt.c
index 4e8704405a3b..3828266af0b8 100644
--- a/crypto/fcrypt.c
+++ b/crypto/fcrypt.c
@@ -306,7 +306,8 @@ static int fcrypt_setkey(struct crypto_tfm *tfm, const u8 *key, unsigned int key
#if BITS_PER_LONG == 64 /* the 64-bit version can also be used for 32-bit
* kernels - it seems to be faster but the code is
- * larger */
+ * larger
+ */
u64 k; /* k holds all 56 non-parity bits */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Crypto: fixed a comment coding style issue
2019-06-23 1:40 [PATCH] Crypto: fixed a comment coding style issue Aditya Parekh
@ 2019-06-24 4:07 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-06-24 4:07 UTC (permalink / raw)
To: Aditya Parekh; +Cc: davem, trivial, linux-crypto
On Sat, Jun 22, 2019 at 09:40:00PM -0400, Aditya Parekh wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Aditya Parekh <kerneladi@gmail.com>
> ---
> crypto/fcrypt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/crypto/fcrypt.c b/crypto/fcrypt.c
> index 4e8704405a3b..3828266af0b8 100644
> --- a/crypto/fcrypt.c
> +++ b/crypto/fcrypt.c
> @@ -306,7 +306,8 @@ static int fcrypt_setkey(struct crypto_tfm *tfm, const u8 *key, unsigned int key
>
> #if BITS_PER_LONG == 64 /* the 64-bit version can also be used for 32-bit
> * kernels - it seems to be faster but the code is
> - * larger */
> + * larger
> + */
>
> u64 k; /* k holds all 56 non-parity bits */
Nack. This patch doesn't improve the code at all.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-24 4:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-23 1:40 [PATCH] Crypto: fixed a comment coding style issue Aditya Parekh
2019-06-24 4:07 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox