From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Eric Biggers <ebiggers@kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH crypto-next v6 0/3] crypto: poly1305 improvements
Date: Tue, 17 Dec 2019 18:44:42 +0100 [thread overview]
Message-ID: <20191217174445.188216-1-Jason@zx2c4.com> (raw)
With no feedback on v5 beyond the need for a .gitignore in the second
commit of this v6, I think this series should now be good to go.
These are some improvements to the Poly1305 code that I think should be
fairly uncontroversial. The first part, the new C implementations, adds
cleaner code in two forms that can easily be compared and reviewed, and
also results in performance speedups. The second part, the new x86_64
implementation, replaces an slow unvetted implementation with an
extremely fast implementation that has received many eyeballs. Finally,
we fix up some deadcode.
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Jason A. Donenfeld (3):
crypto: poly1305 - add new 32 and 64-bit generic versions
crypto: x86_64/poly1305 - add faster implementations
crypto: arm/arm64/mips/poly1305 - remove redundant non-reduction from
emit
arch/arm/crypto/poly1305-glue.c | 18 +-
arch/arm64/crypto/poly1305-glue.c | 18 +-
arch/mips/crypto/poly1305-glue.c | 18 +-
arch/x86/crypto/.gitignore | 1 +
arch/x86/crypto/Makefile | 11 +-
arch/x86/crypto/poly1305-avx2-x86_64.S | 390 ---
arch/x86/crypto/poly1305-sse2-x86_64.S | 590 ----
arch/x86/crypto/poly1305-x86_64.pl | 4266 ++++++++++++++++++++++++
arch/x86/crypto/poly1305_glue.c | 308 +-
crypto/adiantum.c | 4 +-
crypto/nhpoly1305.c | 2 +-
crypto/poly1305_generic.c | 27 +-
include/crypto/internal/poly1305.h | 50 +-
include/crypto/nhpoly1305.h | 4 +-
include/crypto/poly1305.h | 16 +-
lib/crypto/Kconfig | 4 +-
lib/crypto/Makefile | 4 +-
lib/crypto/poly1305-donna32.c | 204 ++
lib/crypto/poly1305-donna64.c | 185 +
lib/crypto/poly1305.c | 174 +-
20 files changed, 4927 insertions(+), 1367 deletions(-)
create mode 100644 arch/x86/crypto/.gitignore
delete mode 100644 arch/x86/crypto/poly1305-avx2-x86_64.S
delete mode 100644 arch/x86/crypto/poly1305-sse2-x86_64.S
create mode 100644 arch/x86/crypto/poly1305-x86_64.pl
create mode 100644 lib/crypto/poly1305-donna32.c
create mode 100644 lib/crypto/poly1305-donna64.c
--
2.24.1
next reply other threads:[~2019-12-17 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 17:44 Jason A. Donenfeld [this message]
2019-12-17 17:44 ` [PATCH crypto-next v6 1/3] crypto: poly1305 - add new 32 and 64-bit generic versions Jason A. Donenfeld
2019-12-18 3:03 ` Eric Biggers
2019-12-17 17:44 ` [PATCH crypto-next v6 2/3] crypto: x86_64/poly1305 - add faster implementations Jason A. Donenfeld
2019-12-18 2:31 ` Eric Biggers
2019-12-17 17:44 ` [PATCH crypto-next v6 3/3] crypto: arm/arm64/mips/poly1305 - remove redundant non-reduction from emit Jason A. Donenfeld
2019-12-18 2:48 ` [PATCH crypto-next v6 0/3] crypto: poly1305 improvements Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217174445.188216-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox