Re: [PATCH crypto-next v6 2/3] crypto: x86_64/poly1305 - add faster implementations

[Eric Biggers <ebiggers@kernel.org>]

On Tue, Dec 17, 2019 at 06:44:44PM +0100, Jason A. Donenfeld wrote:
> 
> While this is CRYPTOGAMS code, the originating code for this happens to
> be derived from OpenSSL's commit 4dfe4310c31c4483705991d9a798ce9be1ed1c68.

This doesn't make sense, since there are changes in this patch that are only in
the CRYPTOGAMS version, not in the OpenSSL 4dfe4310c31c version.

> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Co-developed-by: Samuel Neves <sneves@dei.uc.pt>
> Co-developed-by: Andy Polyakov <appro@openssl.org>

Each "Co-developed-by" always needs its own "Signed-off-by".
See Documentation/process/submitting-patches.rst

> diff --git a/arch/x86/crypto/poly1305-x86_64.pl b/arch/x86/crypto/poly1305-x86_64.pl
> new file mode 100644
> index 000000000000..f994855cdbe2
> --- /dev/null
> +++ b/arch/x86/crypto/poly1305-x86_64.pl
> @@ -0,0 +1,4266 @@
> +#!/usr/bin/env perl
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +#
> +# Copyright (C) 2017-2018 Samuel Neves <sneves@dei.uc.pt>. All Rights Reserved.
> +# Copyright (C) 2017-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
> +# Copyright (C) 2006-2017 CRYPTOGAMS by <appro@openssl.org>. All Rights Reserved.
> +#
> +# This code is taken from the OpenSSL project but the author, Andy Polyakov,
> +# has relicensed it under the licenses specified in the SPDX header above.
> +# The original headers, including the original license headers, are
> +# included below for completeness.

And this says it's taken from the OpenSSL project, not CRYPTOGAMS.

Also how is this copyright 2006?  The newest date in either the OpenSSL or
CRYPTOGAMS versions is March 2015.

Also, can you elaborate on what changes have been made from version actually
being used in production in OpenSSL, and how those changes were vetted?  You
keep claiming that this implementation is extremely well vetted in comparison to
the kernel's existing implementation, so presumably you have something in mind.

- Eric