Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 25/28] crypto: cipher - make crypto_spawn_cipher() take a crypto_cipher_spawn
Date: Sat, 28 Dec 2019 20:57:11 -0600	[thread overview]
Message-ID: <20191229025714.544159-26-ebiggers@kernel.org> (raw)
In-Reply-To: <20191229025714.544159-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

Now that all users of single-block cipher spawns have been converted to
use 'struct crypto_cipher_spawn' rather than the less specifically typed
'struct crypto_spawn', make crypto_spawn_cipher() take a pointer to a
'struct crypto_cipher_spawn' rather than a 'struct crypto_spawn'.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/adiantum.c       | 2 +-
 crypto/ccm.c            | 2 +-
 crypto/cmac.c           | 2 +-
 crypto/skcipher.c       | 2 +-
 crypto/vmac.c           | 2 +-
 crypto/xcbc.c           | 2 +-
 include/crypto/algapi.h | 4 ++--
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/crypto/adiantum.c b/crypto/adiantum.c
index 41cace1d0cb6..177b1bfbd330 100644
--- a/crypto/adiantum.c
+++ b/crypto/adiantum.c
@@ -416,7 +416,7 @@ static int adiantum_init_tfm(struct crypto_skcipher *tfm)
 	if (IS_ERR(streamcipher))
 		return PTR_ERR(streamcipher);
 
-	blockcipher = crypto_spawn_cipher(&ictx->blockcipher_spawn.base);
+	blockcipher = crypto_spawn_cipher(&ictx->blockcipher_spawn);
 	if (IS_ERR(blockcipher)) {
 		err = PTR_ERR(blockcipher);
 		goto err_free_streamcipher;
diff --git a/crypto/ccm.c b/crypto/ccm.c
index 7deb533c7486..987c4d69948a 100644
--- a/crypto/ccm.c
+++ b/crypto/ccm.c
@@ -877,7 +877,7 @@ static int cbcmac_init_tfm(struct crypto_tfm *tfm)
 {
 	struct crypto_cipher *cipher;
 	struct crypto_instance *inst = (void *)tfm->__crt_alg;
-	struct crypto_spawn *spawn = crypto_instance_ctx(inst);
+	struct crypto_cipher_spawn *spawn = crypto_instance_ctx(inst);
 	struct cbcmac_tfm_ctx *ctx = crypto_tfm_ctx(tfm);
 
 	cipher = crypto_spawn_cipher(spawn);
diff --git a/crypto/cmac.c b/crypto/cmac.c
index cb41aab2fe58..cc4f46e2c46f 100644
--- a/crypto/cmac.c
+++ b/crypto/cmac.c
@@ -201,7 +201,7 @@ static int cmac_init_tfm(struct crypto_tfm *tfm)
 {
 	struct crypto_cipher *cipher;
 	struct crypto_instance *inst = (void *)tfm->__crt_alg;
-	struct crypto_spawn *spawn = crypto_instance_ctx(inst);
+	struct crypto_cipher_spawn *spawn = crypto_instance_ctx(inst);
 	struct cmac_tfm_ctx *ctx = crypto_tfm_ctx(tfm);
 
 	cipher = crypto_spawn_cipher(spawn);
diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 0615fead1529..a1a3f47c98e1 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -902,7 +902,7 @@ static int skcipher_setkey_simple(struct crypto_skcipher *tfm, const u8 *key,
 static int skcipher_init_tfm_simple(struct crypto_skcipher *tfm)
 {
 	struct skcipher_instance *inst = skcipher_alg_instance(tfm);
-	struct crypto_spawn *spawn = skcipher_instance_ctx(inst);
+	struct crypto_cipher_spawn *spawn = skcipher_instance_ctx(inst);
 	struct skcipher_ctx_simple *ctx = crypto_skcipher_ctx(tfm);
 	struct crypto_cipher *cipher;
 
diff --git a/crypto/vmac.c b/crypto/vmac.c
index 73538224f9ab..5241b183f8df 100644
--- a/crypto/vmac.c
+++ b/crypto/vmac.c
@@ -598,7 +598,7 @@ static int vmac_final(struct shash_desc *desc, u8 *out)
 static int vmac_init_tfm(struct crypto_tfm *tfm)
 {
 	struct crypto_instance *inst = crypto_tfm_alg_instance(tfm);
-	struct crypto_spawn *spawn = crypto_instance_ctx(inst);
+	struct crypto_cipher_spawn *spawn = crypto_instance_ctx(inst);
 	struct vmac_tfm_ctx *tctx = crypto_tfm_ctx(tfm);
 	struct crypto_cipher *cipher;
 
diff --git a/crypto/xcbc.c b/crypto/xcbc.c
index e35b2346cfb8..5fa700ab4387 100644
--- a/crypto/xcbc.c
+++ b/crypto/xcbc.c
@@ -167,7 +167,7 @@ static int xcbc_init_tfm(struct crypto_tfm *tfm)
 {
 	struct crypto_cipher *cipher;
 	struct crypto_instance *inst = (void *)tfm->__crt_alg;
-	struct crypto_spawn *spawn = crypto_instance_ctx(inst);
+	struct crypto_cipher_spawn *spawn = crypto_instance_ctx(inst);
 	struct xcbc_tfm_ctx *ctx = crypto_tfm_ctx(tfm);
 
 	cipher = crypto_spawn_cipher(spawn);
diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h
index aad3348f60d1..c7c028472e91 100644
--- a/include/crypto/algapi.h
+++ b/include/crypto/algapi.h
@@ -228,12 +228,12 @@ static inline struct crypto_alg *crypto_spawn_cipher_alg(
 }
 
 static inline struct crypto_cipher *crypto_spawn_cipher(
-	struct crypto_spawn *spawn)
+	struct crypto_cipher_spawn *spawn)
 {
 	u32 type = CRYPTO_ALG_TYPE_CIPHER;
 	u32 mask = CRYPTO_ALG_TYPE_MASK;
 
-	return __crypto_cipher_cast(crypto_spawn_tfm(spawn, type, mask));
+	return __crypto_cipher_cast(crypto_spawn_tfm(&spawn->base, type, mask));
 }
 
 static inline struct cipher_alg *crypto_cipher_alg(struct crypto_cipher *tfm)
-- 
2.24.1


  parent reply	other threads:[~2019-12-29  2:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29  2:56 [PATCH 00/28] crypto: template instantiation cleanup Eric Biggers
2019-12-29  2:56 ` [PATCH 01/28] crypto: algapi - make crypto_drop_spawn() a no-op on uninitialized spawns Eric Biggers
2019-12-29  2:56 ` [PATCH 02/28] crypto: algapi - make crypto_grab_spawn() handle an ERR_PTR() name Eric Biggers
2019-12-29  2:56 ` [PATCH 03/28] crypto: shash - make struct shash_instance be the full size Eric Biggers
2019-12-29  2:56 ` [PATCH 04/28] crypto: ahash - make struct ahash_instance " Eric Biggers
2019-12-29  2:56 ` [PATCH 05/28] crypto: skcipher - pass instance to crypto_grab_skcipher() Eric Biggers
2019-12-29  2:56 ` [PATCH 06/28] crypto: aead - pass instance to crypto_grab_aead() Eric Biggers
2019-12-29  2:56 ` [PATCH 07/28] crypto: akcipher - pass instance to crypto_grab_akcipher() Eric Biggers
2019-12-29  2:56 ` [PATCH 08/28] crypto: algapi - pass instance to crypto_grab_spawn() Eric Biggers
2019-12-29  2:56 ` [PATCH 09/28] crypto: shash - introduce crypto_grab_shash() Eric Biggers
2019-12-29  2:56 ` [PATCH 10/28] crypto: ahash - introduce crypto_grab_ahash() Eric Biggers
2019-12-29  2:56 ` [PATCH 11/28] crypto: cipher - introduce crypto_cipher_spawn and crypto_grab_cipher() Eric Biggers
2020-01-01 14:50   ` Eric Biggers
2019-12-29  2:56 ` [PATCH 12/28] crypto: adiantum - use crypto_grab_{cipher,shash} and simplify error paths Eric Biggers
2019-12-29  2:56 ` [PATCH 13/28] crypto: cryptd - use crypto_grab_shash() " Eric Biggers
2019-12-29  2:57 ` [PATCH 14/28] crypto: hmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 15/28] crypto: authenc - use crypto_grab_ahash() " Eric Biggers
2019-12-29  2:57 ` [PATCH 16/28] crypto: authencesn " Eric Biggers
2019-12-29  2:57 ` [PATCH 17/28] crypto: gcm " Eric Biggers
2019-12-29  2:57 ` [PATCH 18/28] crypto: ccm " Eric Biggers
2019-12-29  2:57 ` [PATCH 19/28] crypto: chacha20poly1305 " Eric Biggers
2019-12-29  2:57 ` [PATCH 20/28] crypto: skcipher - use crypto_grab_cipher() " Eric Biggers
2019-12-29  2:57 ` [PATCH 21/28] crypto: cbcmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 22/28] crypto: cmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 23/28] crypto: vmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 24/28] crypto: xcbc " Eric Biggers
2019-12-29  2:57 ` Eric Biggers [this message]
2019-12-29  2:57 ` [PATCH 26/28] crypto: algapi - remove obsoleted instance creation helpers Eric Biggers
2019-12-29  2:57 ` [PATCH 27/28] crypto: ahash - unexport crypto_ahash_type Eric Biggers
2019-12-29  2:57 ` [PATCH 28/28] crypto: algapi - fold crypto_init_spawn() into crypto_grab_spawn() Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229025714.544159-26-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox