Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 27/28] crypto: ahash - unexport crypto_ahash_type
Date: Sat, 28 Dec 2019 20:57:13 -0600	[thread overview]
Message-ID: <20191229025714.544159-28-ebiggers@kernel.org> (raw)
In-Reply-To: <20191229025714.544159-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

Now that all the templates that need ahash spawns have been converted to
use crypto_grab_ahash() rather than look up the algorithm directly,
crypto_ahash_type is no longer used outside of ahash.c.  Make it static.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/ahash.c                 | 5 +++--
 include/crypto/internal/hash.h | 2 --
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/crypto/ahash.c b/crypto/ahash.c
index 2b8449fdb93c..c77717fcea8e 100644
--- a/crypto/ahash.c
+++ b/crypto/ahash.c
@@ -23,6 +23,8 @@
 
 #include "internal.h"
 
+static const struct crypto_type crypto_ahash_type;
+
 struct ahash_request_priv {
 	crypto_completion_t complete;
 	void *data;
@@ -542,7 +544,7 @@ static void crypto_ahash_show(struct seq_file *m, struct crypto_alg *alg)
 		   __crypto_hash_alg_common(alg)->digestsize);
 }
 
-const struct crypto_type crypto_ahash_type = {
+static const struct crypto_type crypto_ahash_type = {
 	.extsize = crypto_ahash_extsize,
 	.init_tfm = crypto_ahash_init_tfm,
 #ifdef CONFIG_PROC_FS
@@ -554,7 +556,6 @@ const struct crypto_type crypto_ahash_type = {
 	.type = CRYPTO_ALG_TYPE_AHASH,
 	.tfmsize = offsetof(struct crypto_ahash, base),
 };
-EXPORT_SYMBOL_GPL(crypto_ahash_type);
 
 int crypto_grab_ahash(struct crypto_ahash_spawn *spawn,
 		      struct crypto_instance *inst,
diff --git a/include/crypto/internal/hash.h b/include/crypto/internal/hash.h
index 79e561abef61..c84b7cb29887 100644
--- a/include/crypto/internal/hash.h
+++ b/include/crypto/internal/hash.h
@@ -57,8 +57,6 @@ struct crypto_shash_spawn {
 	struct crypto_spawn base;
 };
 
-extern const struct crypto_type crypto_ahash_type;
-
 int crypto_hash_walk_done(struct crypto_hash_walk *walk, int err);
 int crypto_hash_walk_first(struct ahash_request *req,
 			   struct crypto_hash_walk *walk);
-- 
2.24.1


  parent reply	other threads:[~2019-12-29  2:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29  2:56 [PATCH 00/28] crypto: template instantiation cleanup Eric Biggers
2019-12-29  2:56 ` [PATCH 01/28] crypto: algapi - make crypto_drop_spawn() a no-op on uninitialized spawns Eric Biggers
2019-12-29  2:56 ` [PATCH 02/28] crypto: algapi - make crypto_grab_spawn() handle an ERR_PTR() name Eric Biggers
2019-12-29  2:56 ` [PATCH 03/28] crypto: shash - make struct shash_instance be the full size Eric Biggers
2019-12-29  2:56 ` [PATCH 04/28] crypto: ahash - make struct ahash_instance " Eric Biggers
2019-12-29  2:56 ` [PATCH 05/28] crypto: skcipher - pass instance to crypto_grab_skcipher() Eric Biggers
2019-12-29  2:56 ` [PATCH 06/28] crypto: aead - pass instance to crypto_grab_aead() Eric Biggers
2019-12-29  2:56 ` [PATCH 07/28] crypto: akcipher - pass instance to crypto_grab_akcipher() Eric Biggers
2019-12-29  2:56 ` [PATCH 08/28] crypto: algapi - pass instance to crypto_grab_spawn() Eric Biggers
2019-12-29  2:56 ` [PATCH 09/28] crypto: shash - introduce crypto_grab_shash() Eric Biggers
2019-12-29  2:56 ` [PATCH 10/28] crypto: ahash - introduce crypto_grab_ahash() Eric Biggers
2019-12-29  2:56 ` [PATCH 11/28] crypto: cipher - introduce crypto_cipher_spawn and crypto_grab_cipher() Eric Biggers
2020-01-01 14:50   ` Eric Biggers
2019-12-29  2:56 ` [PATCH 12/28] crypto: adiantum - use crypto_grab_{cipher,shash} and simplify error paths Eric Biggers
2019-12-29  2:56 ` [PATCH 13/28] crypto: cryptd - use crypto_grab_shash() " Eric Biggers
2019-12-29  2:57 ` [PATCH 14/28] crypto: hmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 15/28] crypto: authenc - use crypto_grab_ahash() " Eric Biggers
2019-12-29  2:57 ` [PATCH 16/28] crypto: authencesn " Eric Biggers
2019-12-29  2:57 ` [PATCH 17/28] crypto: gcm " Eric Biggers
2019-12-29  2:57 ` [PATCH 18/28] crypto: ccm " Eric Biggers
2019-12-29  2:57 ` [PATCH 19/28] crypto: chacha20poly1305 " Eric Biggers
2019-12-29  2:57 ` [PATCH 20/28] crypto: skcipher - use crypto_grab_cipher() " Eric Biggers
2019-12-29  2:57 ` [PATCH 21/28] crypto: cbcmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 22/28] crypto: cmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 23/28] crypto: vmac " Eric Biggers
2019-12-29  2:57 ` [PATCH 24/28] crypto: xcbc " Eric Biggers
2019-12-29  2:57 ` [PATCH 25/28] crypto: cipher - make crypto_spawn_cipher() take a crypto_cipher_spawn Eric Biggers
2019-12-29  2:57 ` [PATCH 26/28] crypto: algapi - remove obsoleted instance creation helpers Eric Biggers
2019-12-29  2:57 ` Eric Biggers [this message]
2019-12-29  2:57 ` [PATCH 28/28] crypto: algapi - fold crypto_init_spawn() into crypto_grab_spawn() Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229025714.544159-28-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox