[PATCH] crypto: inside-secure - Add MODULE_FIRMWARE macros

[PATCH] crypto: inside-secure - Add MODULE_FIRMWARE macros

[Juerg Haefliger]

The safexcel module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.

Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
---
 drivers/crypto/inside-secure/safexcel.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 9ff885d50edf..8198e70169b8 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1997,3 +1997,10 @@ MODULE_AUTHOR("Igal Liberman <igall@marvell.com>");
 MODULE_DESCRIPTION("Support for SafeXcel cryptographic engines: EIP97 & EIP197");
 MODULE_LICENSE("GPL v2");
 MODULE_IMPORT_NS(CRYPTO_INTERNAL);
+
+MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
+MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
+MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
-- 
2.32.0

Re: [PATCH] crypto: inside-secure - Add MODULE_FIRMWARE macros

[Antoine Tenart]

Hello Juerg,

Quoting Juerg Haefliger (2022-04-27 09:03:49)
> +
> +MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");

There's also the old location when the EIP197b firmwares were at the
root of the linux-firmware repo. The driver still supports it, so I
guess those two should have a MODULE_FIRMWARE entry too.

Thanks,
Antoine

Re: [PATCH] crypto: inside-secure - Add MODULE_FIRMWARE macros

[Juerg Haefliger]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Wed, 27 Apr 2022 09:29:14 +0200
"Antoine Tenart" <atenart@kernel.org> wrote:

> Hello Juerg,
>
> Quoting Juerg Haefliger (2022-04-27 09:03:49)
> > +
> > +MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
> > +MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
> > +MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
> > +MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
> > +MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
> > +MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
>
> There's also the old location when the EIP197b firmwares were at the
> root of the linux-firmware repo. The driver still supports it, so I
> guess those two should have a MODULE_FIRMWARE entry too.

Hi Antoine,

Yeah, I was wondering about that myself but wasn't sure if it should be added.
Will add it then and send a v2.

...Juerg


> Thanks,
> Antoine


[-- Attachment #2: attachment.sig --]
[-- Type: application/pgp-signature, Size: 849 bytes --]