From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
Vlad Dronov <vdronov@redhat.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
stable@vger.kernel.org, Adam Guerin <adam.guerin@intel.com>,
Wojciech Ziemba <wojciech.ziemba@intel.com>
Subject: [PATCH v3 07/10] crypto: qat - add param check for RSA
Date: Mon, 9 May 2022 14:34:14 +0100 [thread overview]
Message-ID: <20220509133417.56043-8-giovanni.cabiddu@intel.com> (raw)
In-Reply-To: <20220509133417.56043-1-giovanni.cabiddu@intel.com>
Reject requests with a source buffer that is bigger than the size of the
key. This is to prevent a possible integer underflow that might happen
when copying the source scatterlist into a linear buffer.
Cc: stable@vger.kernel.org
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Adam Guerin <adam.guerin@intel.com>
Reviewed-by: Wojciech Ziemba <wojciech.ziemba@intel.com>
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index d75eb77c9fb9..1021202b2fbd 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -653,6 +653,10 @@ static int qat_rsa_enc(struct akcipher_request *req)
req->dst_len = ctx->key_sz;
return -EOVERFLOW;
}
+
+ if (req->src_len > ctx->key_sz)
+ return -EINVAL;
+
memset(msg, '\0', sizeof(*msg));
ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET(msg->pke_hdr,
ICP_QAT_FW_COMN_REQ_FLAG_SET);
@@ -782,6 +786,10 @@ static int qat_rsa_dec(struct akcipher_request *req)
req->dst_len = ctx->key_sz;
return -EOVERFLOW;
}
+
+ if (req->src_len > ctx->key_sz)
+ return -EINVAL;
+
memset(msg, '\0', sizeof(*msg));
ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET(msg->pke_hdr,
ICP_QAT_FW_COMN_REQ_FLAG_SET);
--
2.35.1
next prev parent reply other threads:[~2022-05-09 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 13:34 [PATCH v3 00/10] crypto: qat - re-enable algorithms Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 01/10] crypto: qat - use pre-allocated buffers in datapath Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 02/10] crypto: qat - refactor submission logic Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 03/10] crypto: qat - add backlog mechanism Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 04/10] crypto: qat - fix memory leak in RSA Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 05/10] crypto: qat - remove dma_free_coherent() for RSA Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 06/10] crypto: qat - remove dma_free_coherent() for DH Giovanni Cabiddu
2022-05-09 13:34 ` Giovanni Cabiddu [this message]
2022-05-09 13:34 ` [PATCH v3 08/10] crypto: qat - add param check " Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 09/10] crypto: qat - honor CRYPTO_TFM_REQ_MAY_SLEEP flag Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 10/10] crypto: qat - re-enable registration of algorithms Giovanni Cabiddu
2022-05-09 14:11 ` Greg KH
2022-05-09 14:47 ` Giovanni Cabiddu
2022-05-20 5:57 ` [PATCH v3 00/10] crypto: qat - re-enable algorithms Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509133417.56043-8-giovanni.cabiddu@intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=adam.guerin@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=stable@vger.kernel.org \
--cc=vdronov@redhat.com \
--cc=wojciech.ziemba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox