Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
	qat-linux@intel.com, Vlad Dronov <vdronov@redhat.com>,
	stable@vger.kernel.org,
	Marco Chiappero <marco.chiappero@intel.com>,
	Adam Guerin <adam.guerin@intel.com>,
	Wojciech Ziemba <wojciech.ziemba@intel.com>
Subject: Re: [PATCH v3 10/10] crypto: qat - re-enable registration of algorithms
Date: Mon, 9 May 2022 16:11:27 +0200	[thread overview]
Message-ID: <YnkhD5YY3thCMkgX@kroah.com> (raw)
In-Reply-To: <20220509133417.56043-11-giovanni.cabiddu@intel.com>

On Mon, May 09, 2022 at 02:34:17PM +0100, Giovanni Cabiddu wrote:
> Re-enable the registration of algorithms after fixes to (1) use
> pre-allocated buffers in the datapath and (2) support the
> CRYPTO_TFM_REQ_MAY_BACKLOG flag.
> 
> This reverts commit 8893d27ffcaf6ec6267038a177cb87bcde4dd3de.

Then why not just have this be a "normal" revert commit?

And why is this ok for stable kernels?  This feels like a new feature
(i.e. the code finally works.)  Why not just have users who want to use
this use a newer kernel?  What bugfix does this resolve in older kernels
(and "the driver did not work" is not really a good reason.)

thanks,

greg k-h

  reply	other threads:[~2022-05-09 14:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 13:34 [PATCH v3 00/10] crypto: qat - re-enable algorithms Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 01/10] crypto: qat - use pre-allocated buffers in datapath Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 02/10] crypto: qat - refactor submission logic Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 03/10] crypto: qat - add backlog mechanism Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 04/10] crypto: qat - fix memory leak in RSA Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 05/10] crypto: qat - remove dma_free_coherent() for RSA Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 06/10] crypto: qat - remove dma_free_coherent() for DH Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 07/10] crypto: qat - add param check for RSA Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 08/10] crypto: qat - add param check for DH Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 09/10] crypto: qat - honor CRYPTO_TFM_REQ_MAY_SLEEP flag Giovanni Cabiddu
2022-05-09 13:34 ` [PATCH v3 10/10] crypto: qat - re-enable registration of algorithms Giovanni Cabiddu
2022-05-09 14:11   ` Greg KH [this message]
2022-05-09 14:47     ` Giovanni Cabiddu
2022-05-20  5:57 ` [PATCH v3 00/10] crypto: qat - re-enable algorithms Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnkhD5YY3thCMkgX@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adam.guerin@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=marco.chiappero@intel.com \
    --cc=qat-linux@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=vdronov@redhat.com \
    --cc=wojciech.ziemba@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox