From: Vladis Dronov <vdronov@redhat.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net
Cc: nstange@suse.de, elliott@hpe.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, smueller@chronox.de,
vdronov@redhat.com
Subject: [PATCH 5/6] crypto: testmgr - disallow plain ghash in FIPS mode
Date: Wed, 21 Dec 2022 23:41:10 +0100 [thread overview]
Message-ID: <20221221224111.19254-6-vdronov@redhat.com> (raw)
In-Reply-To: <20221221224111.19254-1-vdronov@redhat.com>
From: Nicolai Stange <nstange@suse.de>
ghash may be used only as part of the gcm(aes) construction in FIPS
mode. Since commit d6097b8d5d55 ("crypto: api - allow algs only in specific
constructions in FIPS mode") there's support for using spawns which by
itself are marked as non-approved from approved template instantiations.
So simply mark plain ghash as non-approved in testmgr to block any attempts
of direct instantiations in FIPS mode.
Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
---
crypto/testmgr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 562463a77a76..a223cf5f3626 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -5125,7 +5125,6 @@ static const struct alg_test_desc alg_test_descs[] = {
}, {
.alg = "ghash",
.test = alg_test_hash,
- .fips_allowed = 1,
.suite = {
.hash = __VECS(ghash_tv_template)
}
--
2.38.1
next prev parent reply other threads:[~2022-12-21 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 22:41 [PATCH 0/6] Trivial set of FIPS 140-3 related changes Vladis Dronov
2022-12-21 22:41 ` [PATCH 1/6] crypto: xts - restrict key lengths to approved values in FIPS mode Vladis Dronov
2022-12-21 22:41 ` [PATCH 2/6] crypto: xts - drop xts_check_key() Vladis Dronov
2022-12-21 23:33 ` Eric Biggers
2022-12-22 16:41 ` Vladis Dronov
2022-12-21 22:41 ` [PATCH 3/6] crypto: xts - drop redundant xts key check Vladis Dronov
2022-12-21 22:41 ` [PATCH 4/6] crypto: testmgr - disallow plain cbcmac(aes) in FIPS mode Vladis Dronov
2022-12-21 22:41 ` Vladis Dronov [this message]
2022-12-21 22:41 ` [PATCH 6/6] crypto: testmgr - allow ecdsa-nist-p256 and -p384 " Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221224111.19254-6-vdronov@redhat.com \
--to=vdronov@redhat.com \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nstange@suse.de \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox