* [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS
@ 2023-05-20 17:31 Eric Biggers
2023-05-20 17:39 ` Ard Biesheuvel
2023-05-24 10:17 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2023-05-20 17:31 UTC (permalink / raw)
To: linux-crypto
From: Eric Biggers <ebiggers@google.com>
Make the help text for CRYPTO_STATS explicitly mention that it reduces
the performance of the crypto API.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 42751d63cd4d9..fdf3742f1106b 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1393,6 +1393,9 @@ config CRYPTO_STATS
help
Enable the gathering of crypto stats.
+ Enabling this option reduces the performance of the crypto API. It
+ should only be enabled when there is actually a use case for it.
+
This collects data sizes, numbers of requests, and numbers
of errors processed by:
- AEAD ciphers (encrypt, decrypt)
base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS
2023-05-20 17:31 [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS Eric Biggers
@ 2023-05-20 17:39 ` Ard Biesheuvel
2023-05-24 10:17 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-05-20 17:39 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto
On Sat, 20 May 2023 at 19:31, Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Make the help text for CRYPTO_STATS explicitly mention that it reduces
> the performance of the crypto API.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 42751d63cd4d9..fdf3742f1106b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1393,6 +1393,9 @@ config CRYPTO_STATS
> help
> Enable the gathering of crypto stats.
>
> + Enabling this option reduces the performance of the crypto API. It
> + should only be enabled when there is actually a use case for it.
> +
> This collects data sizes, numbers of requests, and numbers
> of errors processed by:
> - AEAD ciphers (encrypt, decrypt)
>
> base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS
2023-05-20 17:31 [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS Eric Biggers
2023-05-20 17:39 ` Ard Biesheuvel
@ 2023-05-24 10:17 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-05-24 10:17 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Make the help text for CRYPTO_STATS explicitly mention that it reduces
> the performance of the crypto API.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-24 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-20 17:31 [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS Eric Biggers
2023-05-20 17:39 ` Ard Biesheuvel
2023-05-24 10:17 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox