[herbert-cryptodev-2.6:master 45/47] drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'?

[herbert-cryptodev-2.6:master 45/47] drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   1d217fa26680b074dbb44f6183f971a5304eaf8b
commit: 9260db6640a61ebba5348ceae7fa26307d9d5b0e [45/47] crypto: qat - move dbgfs init to separate file
config: parisc-randconfig-r005-20230531 (https://download.01.org/0day-ci/archive/20230603/202306030654.5t4qkyN1-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=9260db6640a61ebba5348ceae7fa26307d9d5b0e
        git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
        git fetch --no-tags herbert-cryptodev-2.6 master
        git checkout 9260db6640a61ebba5348ceae7fa26307d9d5b0e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=parisc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/crypto/intel/qat/qat_c3xxxvf/ drivers/crypto/intel/qat/qat_c62x/ drivers/crypto/intel/qat/qat_dh895xcc/ fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306030654.5t4qkyN1-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c: In function 'adf_cleanup_accel':
>> drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
      69 |         adf_dbgfs_exit(accel_dev);
         |         ^~~~~~~~~~~~~~
         |         adf_dbgfs_init
   cc1: some warnings being treated as errors
--
   drivers/crypto/intel/qat/qat_c62x/adf_drv.c: In function 'adf_cleanup_accel':
>> drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
      69 |         adf_dbgfs_exit(accel_dev);
         |         ^~~~~~~~~~~~~~
         |         adf_dbgfs_init
   cc1: some warnings being treated as errors
--
   drivers/crypto/intel/qat/qat_c3xxxvf/adf_drv.c: In function 'adf_cleanup_accel':
>> drivers/crypto/intel/qat/qat_c3xxxvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
      68 |         adf_dbgfs_exit(accel_dev);
         |         ^~~~~~~~~~~~~~
         |         adf_dbgfs_init
   cc1: some warnings being treated as errors


vim +69 drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c

    45	
    46	static void adf_cleanup_accel(struct adf_accel_dev *accel_dev)
    47	{
    48		struct adf_accel_pci *accel_pci_dev = &accel_dev->accel_pci_dev;
    49		int i;
    50	
    51		for (i = 0; i < ADF_PCI_MAX_BARS; i++) {
    52			struct adf_bar *bar = &accel_pci_dev->pci_bars[i];
    53	
    54			if (bar->virt_addr)
    55				pci_iounmap(accel_pci_dev->pci_dev, bar->virt_addr);
    56		}
    57	
    58		if (accel_dev->hw_device) {
    59			switch (accel_pci_dev->pci_dev->device) {
    60			case PCI_DEVICE_ID_INTEL_QAT_DH895XCC:
    61				adf_clean_hw_data_dh895xcc(accel_dev->hw_device);
    62				break;
    63			default:
    64				break;
    65			}
    66			kfree(accel_dev->hw_device);
    67			accel_dev->hw_device = NULL;
    68		}
  > 69		adf_dbgfs_exit(accel_dev);
    70		adf_cfg_dev_remove(accel_dev);
    71		adf_devmgr_rm_dev(accel_dev, NULL);
    72	}
    73	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [herbert-cryptodev-2.6:master 45/47] drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'?

[Giovanni Cabiddu]

On Sat, Jun 03, 2023 at 06:58:35AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   1d217fa26680b074dbb44f6183f971a5304eaf8b
> commit: 9260db6640a61ebba5348ceae7fa26307d9d5b0e [45/47] crypto: qat - move dbgfs init to separate file
> config: parisc-randconfig-r005-20230531 (https://download.01.org/0day-ci/archive/20230603/202306030654.5t4qkyN1-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 12.3.0
> reproduce (this is a W=1 build):
>         mkdir -p ~/bin
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=9260db6640a61ebba5348ceae7fa26307d9d5b0e
>         git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
>         git fetch --no-tags herbert-cryptodev-2.6 master
>         git checkout 9260db6640a61ebba5348ceae7fa26307d9d5b0e
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=parisc olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/crypto/intel/qat/qat_c3xxxvf/ drivers/crypto/intel/qat/qat_c62x/ drivers/crypto/intel/qat/qat_dh895xcc/ fs/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306030654.5t4qkyN1-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c: In function 'adf_cleanup_accel':
> >> drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
>       69 |         adf_dbgfs_exit(accel_dev);
>          |         ^~~~~~~~~~~~~~
>          |         adf_dbgfs_init
>    cc1: some warnings being treated as errors
adf_dbgfs.h is not defining adf_dbgfs_exit() when CONFIG_DEBUG_FS=n.

My bad. I thought I had a build with CONFIG_DEBUG_FS=n in my flow but I
just realized it is not working as expected (CONFIG_DEBUG_FS was forced
to y).

Sending a fix...

Regards,

-- 
Giovanni