From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
linux-crypto@vger.kernel.org, qat-linux@intel.com
Subject: Re: Bug in rsa-pkcs1pad in 6.1 and 5.15
Date: Thu, 7 Sep 2023 11:15:30 +0100 [thread overview]
Message-ID: <2023090724-campfire-unstirred-a36e@gregkh> (raw)
In-Reply-To: <ZPiNIBvrpVz61doJ@gcabiddu-mobl1.ger.corp.intel.com>
On Wed, Sep 06, 2023 at 03:30:56PM +0100, Giovanni Cabiddu wrote:
> On Wed, Sep 06, 2023 at 05:05:14PM +0800, Herbert Xu wrote:
> > On Tue, Sep 05, 2023 at 11:41:14AM +0100, Giovanni Cabiddu wrote:
> > >
> > > Options:
> > > 1. Cherry-pick 5b11d1a360ea ("crypto: rsa-pkcs1pad - Use helper to set
> > > reqsize") to both 6.1.x and 5.15.x trees.
> > > 2. Revert upstream commit 80e62ad58db0 ("crypto: qat - Use helper
> > > to set reqsize").
> > > In 6.1 revert da1729e6619c414f34ce679247721603ebb957dc
> > > In 5.15 revert 3894f5880f968f81c6f3ed37d96bdea01441a8b7
> > >
> > > Option #1 is preferred as the same problem might be impacting other
> > > akcipher implementations besides QAT. Option #2 is just specific to the
> > > QAT driver.
> > >
> > > @Herbert, can you have a quick look in case I missed something? I tried
> > > both options in 6.1.51 and they appear to resolve the problem.
> >
> > Yes I think backporting the rsa-pkcs1pad would be the best way
> > forward.
> Thanks Herbert.
>
> Adding stable to the TO list. Would it be possible to cherry-pick the
> following upstream commit
>
> 5b11d1a360ea ("crypto: rsa-pkcs1pad - Use helper to set reqsize")
>
> to both the 6.1.x and 5.15.x trees?
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-09-07 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:41 Bug in rsa-pkcs1pad in 6.1 and 5.15 Giovanni Cabiddu
2023-09-05 12:23 ` Giovanni Cabiddu
2023-09-06 9:05 ` Herbert Xu
2023-09-06 14:30 ` Giovanni Cabiddu
2023-09-07 10:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023090724-campfire-unstirred-a36e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox