From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Sasha Levin <sashal@kernel.org>,
linux-crypto@vger.kernel.org, qat-linux@intel.com,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Bug in rsa-pkcs1pad in 6.1 and 5.15
Date: Wed, 6 Sep 2023 17:05:14 +0800 [thread overview]
Message-ID: <ZPhAyty1r8ASyr+F@gondor.apana.org.au> (raw)
In-Reply-To: <ZPcFyp4jdE3uSeqW@gcabiddu-mobl1.ger.corp.intel.com>
On Tue, Sep 05, 2023 at 11:41:14AM +0100, Giovanni Cabiddu wrote:
>
> Options:
> 1. Cherry-pick 5b11d1a360ea ("crypto: rsa-pkcs1pad - Use helper to set
> reqsize") to both 6.1.x and 5.15.x trees.
> 2. Revert upstream commit 80e62ad58db0 ("crypto: qat - Use helper
> to set reqsize").
> In 6.1 revert da1729e6619c414f34ce679247721603ebb957dc
> In 5.15 revert 3894f5880f968f81c6f3ed37d96bdea01441a8b7
>
> Option #1 is preferred as the same problem might be impacting other
> akcipher implementations besides QAT. Option #2 is just specific to the
> QAT driver.
>
> @Herbert, can you have a quick look in case I missed something? I tried
> both options in 6.1.51 and they appear to resolve the problem.
Yes I think backporting the rsa-pkcs1pad would be the best way
forward.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-09-06 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:41 Bug in rsa-pkcs1pad in 6.1 and 5.15 Giovanni Cabiddu
2023-09-05 12:23 ` Giovanni Cabiddu
2023-09-06 9:05 ` Herbert Xu [this message]
2023-09-06 14:30 ` Giovanni Cabiddu
2023-09-07 10:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPhAyty1r8ASyr+F@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=giovanni.cabiddu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox