Linux cryptographic layer development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: jeshwank <JESHWANTHKUMAR.NK@amd.com>,
	thomas.lendacky@amd.com, john.allen@amd.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	jens.wiklander@linaro.org, sumit.garg@linaro.org,
	jarkko.nikula@linux.intel.com, mario.limonciello@amd.com,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	op-tee@lists.trustedfirmware.org
Cc: oe-kbuild-all@lists.linux.dev, Mythri.Pandeshwarakrishna@amd.com,
	Devaraj.Rangasamy@amd.com, Rijo-john.Thomas@amd.com,
	nimesh.easow@amd.com, JESHWANTHKUMAR.NK@amd.com
Subject: Re: [PATCH 2/3] crypto: ccp - Use psp_tee_alloc_buffer() and psp_tee_free_buffer()
Date: Thu, 26 Oct 2023 05:26:13 +0800	[thread overview]
Message-ID: <202310260529.GEey5HQc-lkp@intel.com> (raw)
In-Reply-To: <20231025065700.1556152-3-JESHWANTHKUMAR.NK@amd.com>

Hi jeshwank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-crypto-2.6/master]
[also build test WARNING on linus/master v6.6-rc7]
[cannot apply to herbert-cryptodev-2.6/master next-20231025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jeshwank/crypto-ccp-Add-function-to-allocate-and-free-memory-using-DMA-APIs/20231025-150420
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
patch link:    https://lore.kernel.org/r/20231025065700.1556152-3-JESHWANTHKUMAR.NK%40amd.com
patch subject: [PATCH 2/3] crypto: ccp - Use psp_tee_alloc_buffer() and psp_tee_free_buffer()
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231026/202310260529.GEey5HQc-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310260529.GEey5HQc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310260529.GEey5HQc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/crypto/ccp/tee-dev.c:123:24: warning: no previous prototype for 'tee_alloc_cmd_buffer' [-Wmissing-prototypes]
     123 | struct psp_tee_buffer *tee_alloc_cmd_buffer(struct psp_tee_device *tee)
         |                        ^~~~~~~~~~~~~~~~~~~~


vim +/tee_alloc_cmd_buffer +123 drivers/crypto/ccp/tee-dev.c

   122	
 > 123	struct psp_tee_buffer *tee_alloc_cmd_buffer(struct psp_tee_device *tee)
   124	{
   125		struct tee_init_ring_cmd *cmd;
   126		struct psp_tee_buffer *cmd_buffer;
   127	
   128		cmd_buffer = psp_tee_alloc_buffer(sizeof(*cmd),
   129						  GFP_KERNEL | __GFP_ZERO);
   130		if (!cmd_buffer)
   131			return NULL;
   132	
   133		cmd = (struct tee_init_ring_cmd *)cmd_buffer->vaddr;
   134		cmd->hi_addr = upper_32_bits(tee->rb_mgr.ring_buf->paddr);
   135		cmd->low_addr = lower_32_bits(tee->rb_mgr.ring_buf->paddr);
   136		cmd->size = tee->rb_mgr.ring_buf->size;
   137	
   138		dev_dbg(tee->dev, "tee: ring address: high = 0x%x low = 0x%x size = %u\n",
   139			cmd->hi_addr, cmd->low_addr, cmd->size);
   140	
   141		return cmd_buffer;
   142	}
   143	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2023-10-25 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25  6:56 [PATCH 0/3] Introduce DMA APIs to allocate and free TEE shared memory jeshwank
2023-10-25  6:56 ` [PATCH 1/3] crypto: ccp - Add function to allocate and free memory using DMA APIs jeshwank
2023-10-27  5:24   ` Christoph Hellwig
2023-10-30  6:05     ` NK, JESHWANTHKUMAR
     [not found]     ` <94059f5c-10dd-4d75-a69c-76b21ff49546@amd.com>
2023-10-30 13:33       ` Christoph Hellwig
2023-11-01 14:12         ` NK, JESHWANTHKUMAR
2023-10-25  6:56 ` [PATCH 2/3] crypto: ccp - Use psp_tee_alloc_buffer() and psp_tee_free_buffer() jeshwank
2023-10-25 21:26   ` kernel test robot [this message]
2023-10-25  6:57 ` [PATCH 3/3] tee: amdtee: " jeshwank
2023-10-25 13:31 ` [PATCH 0/3] Introduce DMA APIs to allocate and free TEE shared memory Sumit Garg
2023-10-26 10:30   ` NK, JESHWANTHKUMAR
2023-10-26 14:53     ` Tom Lendacky
2023-10-30  6:21       ` NK, JESHWANTHKUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310260529.GEey5HQc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Devaraj.Rangasamy@amd.com \
    --cc=JESHWANTHKUMAR.NK@amd.com \
    --cc=Mythri.Pandeshwarakrishna@amd.com \
    --cc=Rijo-john.Thomas@amd.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jens.wiklander@linaro.org \
    --cc=john.allen@amd.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nimesh.easow@amd.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=sumit.garg@linaro.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox