From: Christoph Hellwig <hch@infradead.org>
To: jeshwank <JESHWANTHKUMAR.NK@amd.com>
Cc: thomas.lendacky@amd.com, john.allen@amd.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
jens.wiklander@linaro.org, sumit.garg@linaro.org,
jarkko.nikula@linux.intel.com, mario.limonciello@amd.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
op-tee@lists.trustedfirmware.org,
Mythri.Pandeshwarakrishna@amd.com, Devaraj.Rangasamy@amd.com,
Rijo-john.Thomas@amd.com, nimesh.easow@amd.com
Subject: Re: [PATCH 1/3] crypto: ccp - Add function to allocate and free memory using DMA APIs
Date: Thu, 26 Oct 2023 22:24:05 -0700 [thread overview]
Message-ID: <ZTtJdU5a/P4kg/Ss@infradead.org> (raw)
In-Reply-To: <20231025065700.1556152-2-JESHWANTHKUMAR.NK@amd.com>
On Wed, Oct 25, 2023 at 12:26:58PM +0530, jeshwank wrote:
> + tee_buf->vaddr = dma_alloc_coherent(psp->dev, size, &tee_buf->dma, gfp);
> + if (!tee_buf->vaddr || !tee_buf->dma) {
> + kfree(tee_buf);
> + return NULL;
> + }
> +
> + tee_buf->size = size;
> +
> + /* Check whether IOMMU is present. If present, translate IOVA
> + * to physical address, else the dma handle is the physical
> + * address.
> + */
> + dom = iommu_get_domain_for_dev(psp->dev);
> + if (dom)
> + tee_buf->paddr = iommu_iova_to_phys(dom, tee_buf->dma);
> + else
No, you can't mix the DMA API and iommu API. You need to stick to one
or the other.
next prev parent reply other threads:[~2023-10-27 5:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 6:56 [PATCH 0/3] Introduce DMA APIs to allocate and free TEE shared memory jeshwank
2023-10-25 6:56 ` [PATCH 1/3] crypto: ccp - Add function to allocate and free memory using DMA APIs jeshwank
2023-10-27 5:24 ` Christoph Hellwig [this message]
2023-10-30 6:05 ` NK, JESHWANTHKUMAR
[not found] ` <94059f5c-10dd-4d75-a69c-76b21ff49546@amd.com>
2023-10-30 13:33 ` Christoph Hellwig
2023-11-01 14:12 ` NK, JESHWANTHKUMAR
2023-10-25 6:56 ` [PATCH 2/3] crypto: ccp - Use psp_tee_alloc_buffer() and psp_tee_free_buffer() jeshwank
2023-10-25 21:26 ` kernel test robot
2023-10-25 6:57 ` [PATCH 3/3] tee: amdtee: " jeshwank
2023-10-25 13:31 ` [PATCH 0/3] Introduce DMA APIs to allocate and free TEE shared memory Sumit Garg
2023-10-26 10:30 ` NK, JESHWANTHKUMAR
2023-10-26 14:53 ` Tom Lendacky
2023-10-30 6:21 ` NK, JESHWANTHKUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTtJdU5a/P4kg/Ss@infradead.org \
--to=hch@infradead.org \
--cc=Devaraj.Rangasamy@amd.com \
--cc=JESHWANTHKUMAR.NK@amd.com \
--cc=Mythri.Pandeshwarakrishna@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=jens.wiklander@linaro.org \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nimesh.easow@amd.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox