From: Eric Biggers <ebiggers@kernel.org>
To: James Prestwood <prestwoj@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Karel Balej <balejk@matfyz.cz>,
dimitri.ledkov@canonical.com, alexandre.torgue@foss.st.com,
davem@davemloft.net, dhowells@redhat.com,
herbert@gondor.apana.org.au, keyrings@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, mcgrof@kernel.org,
mcoquelin.stm32@gmail.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, iwd@lists.linux.dev
Subject: Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support
Date: Wed, 13 Mar 2024 12:44:23 -0700 [thread overview]
Message-ID: <20240313194423.GA1111@sol.localdomain> (raw)
In-Reply-To: <f2dcbe55-0f0e-4173-8e21-f899c6fc802a@gmail.com>
On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote:
> Hi,
>
> On 3/13/24 1:56 AM, Johannes Berg wrote:
> > Not sure why you're CC'ing the world, but I guess adding a few more
> > doesn't hurt ...
> >
> > On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote:
> > > and I use iwd
> > This is your problem, the wireless stack in the kernel doesn't use any
> > kernel crypto code for 802.1X.
>
> Yes, the wireless stack has zero bearing on the issue. I think that's what
> you meant by "problem".
>
> IWD has used the kernel crypto API forever which was abruptly broken, that
> is the problem.
>
> The original commit says it was to remove support for sha1 signed kernel
> modules, but it did more than that and broke the keyctl API.
>
Which specific API is iwd using that is relevant here?
I cloned https://kernel.googlesource.com/pub/scm/network/wireless/iwd
and grepped for keyctl and AF_ALG, but there are no matches.
- Eric
next prev parent reply other threads:[~2024-03-13 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 21:22 [PATCH] crypto: pkcs7: remove sha1 support Dimitri John Ledkov
2023-10-20 5:54 ` Herbert Xu
2024-03-13 8:50 ` [REGRESSION] " Karel Balej
2024-03-13 8:56 ` Johannes Berg
2024-03-13 17:26 ` James Prestwood
2024-03-13 19:44 ` Eric Biggers [this message]
2024-03-13 20:12 ` James Prestwood
2024-03-13 20:22 ` Eric Biggers
2024-03-13 21:17 ` James Prestwood
2024-03-13 22:10 ` Eric Biggers
2024-03-13 22:51 ` Jeff Johnson
2024-03-13 23:06 ` Eric Biggers
2024-03-13 23:40 ` Eric Biggers
2024-03-14 11:52 ` James Prestwood
2024-03-14 12:22 ` James Bottomley
2024-03-14 20:20 ` Eric Biggers
2024-03-14 23:38 ` Ard Biesheuvel
2024-03-13 18:39 ` Michael Yartys
2024-03-13 19:54 ` Karel Balej
2024-03-15 13:09 ` Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313194423.GA1111@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=balejk@matfyz.cz \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dimitri.ledkov@canonical.com \
--cc=herbert@gondor.apana.org.au \
--cc=iwd@lists.linux.dev \
--cc=johannes@sipsolutions.net \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox