From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc: David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Luis Chamberlain <mcgrof@kernel.org>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-modules@vger.kernel.org
Subject: Re: [PATCH] crypto: pkcs7: remove sha1 support
Date: Fri, 20 Oct 2023 13:54:29 +0800 [thread overview]
Message-ID: <ZTIWFcFgpOsaE05N@gondor.apana.org.au> (raw)
In-Reply-To: <20231010212240.61637-1-dimitri.ledkov@canonical.com>
On Tue, Oct 10, 2023 at 10:22:38PM +0100, Dimitri John Ledkov wrote:
> Removes support for sha1 signed kernel modules, importing sha1 signed
> x.509 certificates.
>
> rsa-pkcs1pad keeps sha1 padding support, which seems to be used by
> virtio driver.
>
> sha1 remains available as there are many drivers and subsystems using
> it. Note only hmac(sha1) with secret keys remains cryptographically
> secure.
>
> In the kernel there are filesystems, IMA, tpm/pcr that appear to be
> using sha1. Maybe they can all start to be slowly upgraded to
> something else i.e. blake3, ParallelHash, SHAKE256 as needed.
>
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> ---
> crypto/asymmetric_keys/mscode_parser.c | 3 -
> crypto/asymmetric_keys/pkcs7_parser.c | 4 --
> crypto/asymmetric_keys/public_key.c | 3 +-
> crypto/asymmetric_keys/signature.c | 2 +-
> crypto/asymmetric_keys/x509_cert_parser.c | 8 ---
> crypto/testmgr.h | 80 -----------------------
> include/linux/oid_registry.h | 4 --
> kernel/module/Kconfig | 5 --
> 8 files changed, 2 insertions(+), 107 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-10-20 5:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 21:22 [PATCH] crypto: pkcs7: remove sha1 support Dimitri John Ledkov
2023-10-20 5:54 ` Herbert Xu [this message]
2024-03-13 8:50 ` [REGRESSION] " Karel Balej
2024-03-13 8:56 ` Johannes Berg
2024-03-13 17:26 ` James Prestwood
2024-03-13 19:44 ` Eric Biggers
2024-03-13 20:12 ` James Prestwood
2024-03-13 20:22 ` Eric Biggers
2024-03-13 21:17 ` James Prestwood
2024-03-13 22:10 ` Eric Biggers
2024-03-13 22:51 ` Jeff Johnson
2024-03-13 23:06 ` Eric Biggers
2024-03-13 23:40 ` Eric Biggers
2024-03-14 11:52 ` James Prestwood
2024-03-14 12:22 ` James Bottomley
2024-03-14 20:20 ` Eric Biggers
2024-03-14 23:38 ` Ard Biesheuvel
2024-03-13 18:39 ` Michael Yartys
2024-03-13 19:54 ` Karel Balej
2024-03-15 13:09 ` Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTIWFcFgpOsaE05N@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dimitri.ledkov@canonical.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcgrof@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox