Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
	<linux-crypto@vger.kernel.org>,
	Richard Hughes <hughsient@gmail.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 5/5] crypto: ccp: Move message about TSME being enabled later in init
Date: Tue, 28 May 2024 16:07:12 -0500	[thread overview]
Message-ID: <20240528210712.1268-6-mario.limonciello@amd.com> (raw)
In-Reply-To: <20240528210712.1268-1-mario.limonciello@amd.com>

Some of the security attributes data is now populated from an HSTI
command on some processors, so show the message after it has been
populated.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v1->v2:
 * Move code from patch 4
---
 drivers/crypto/ccp/hsti.c    | 15 +++++++++++++++
 drivers/crypto/ccp/psp-dev.c |  8 --------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/drivers/crypto/ccp/hsti.c b/drivers/crypto/ccp/hsti.c
index 8b99bbd4efe2..1b39a4fb55c0 100644
--- a/drivers/crypto/ccp/hsti.c
+++ b/drivers/crypto/ccp/hsti.c
@@ -119,5 +119,20 @@ int psp_init_hsti(struct psp_device *psp)
 			return ret;
 	}
 
+	/*
+	 * At this stage, if security information hasn't been populated by
+	 * either the PSP or by the driver through the platform command,
+	 * then there is nothing more to do.
+	 */
+	if (!psp->capability.security_reporting)
+		return 0;
+
+	if (psp->capability.tsme_status) {
+		if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
+			dev_notice(psp->dev, "psp: Both TSME and SME are active, SME is unnecessary when TSME is active.\n");
+		else
+			dev_notice(psp->dev, "psp: TSME enabled\n");
+	}
+
 	return 0;
 }
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
index 0a01ad134609..1c5a7189631e 100644
--- a/drivers/crypto/ccp/psp-dev.c
+++ b/drivers/crypto/ccp/psp-dev.c
@@ -157,14 +157,6 @@ static unsigned int psp_get_capability(struct psp_device *psp)
 	}
 	psp->capability.raw = val;
 
-	/* Detect TSME and/or SME status */
-	if (psp->capability.security_reporting && psp->capability.tsme_status) {
-		if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-			dev_notice(psp->dev, "psp: Both TSME and SME are active, SME is unnecessary when TSME is active.\n");
-		else
-			dev_notice(psp->dev, "psp: TSME enabled\n");
-	}
-
 	return 0;
 }
 
-- 
2.43.0


  parent reply	other threads:[~2024-05-28 21:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 21:07 [PATCH v2 0/5] Enable PSP security attributes on more SoCs Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 1/5] crypto: ccp: Represent capabilities register as a union Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 2/5] crypto: ccp: Move security attributes to their own file Mario Limonciello
2024-05-29 15:20   ` Tom Lendacky
2024-05-29 16:22     ` Mario Limonciello
2024-05-29 16:50       ` Tom Lendacky
2024-05-28 21:07 ` [PATCH v2 3/5] crypto: ccp: align psp_platform_access_msg Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 4/5] crypto: ccp: Add support for getting security attributes on some older systems Mario Limonciello
2024-05-29 15:21   ` Tom Lendacky
2024-05-28 21:07 ` Mario Limonciello [this message]
2024-05-29 15:22   ` [PATCH v2 5/5] crypto: ccp: Move message about TSME being enabled later in init Tom Lendacky
2024-05-29  8:07 ` [PATCH v2 0/5] Enable PSP security attributes on more SoCs Richard Hughes
2024-06-07 11:54 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528210712.1268-6-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hughsient@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox