From: Mario Limonciello <mario.limonciello@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
<linux-crypto@vger.kernel.org>,
Richard Hughes <hughsient@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own file
Date: Wed, 29 May 2024 11:22:04 -0500 [thread overview]
Message-ID: <e29a975a-cb63-43cb-a421-8d7dd5ca36a6@amd.com> (raw)
In-Reply-To: <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
On 5/29/2024 10:20, Tom Lendacky wrote:
> On 5/28/24 16:07, Mario Limonciello wrote:
>> To prepare for other code that will manipulate security attributes
>> move the handling code out of sp-pci.c. No intended functional changes.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v1->v2:
>> * Only add psp_security_attr_group when PSP support enabled
>> (Fixes lkp robot reported Kconfig issue)
>
> Just verifying that there's no change in behavior in regards to whether
> the attributes are shown. Previously the attributes were not shown if
> CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would be NULL in
> psp_security_is_visible(), right?
Yes; that's right.
next prev parent reply other threads:[~2024-05-29 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 21:07 [PATCH v2 0/5] Enable PSP security attributes on more SoCs Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 1/5] crypto: ccp: Represent capabilities register as a union Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 2/5] crypto: ccp: Move security attributes to their own file Mario Limonciello
2024-05-29 15:20 ` Tom Lendacky
2024-05-29 16:22 ` Mario Limonciello [this message]
2024-05-29 16:50 ` Tom Lendacky
2024-05-28 21:07 ` [PATCH v2 3/5] crypto: ccp: align psp_platform_access_msg Mario Limonciello
2024-05-28 21:07 ` [PATCH v2 4/5] crypto: ccp: Add support for getting security attributes on some older systems Mario Limonciello
2024-05-29 15:21 ` Tom Lendacky
2024-05-28 21:07 ` [PATCH v2 5/5] crypto: ccp: Move message about TSME being enabled later in init Mario Limonciello
2024-05-29 15:22 ` Tom Lendacky
2024-05-29 8:07 ` [PATCH v2 0/5] Enable PSP security attributes on more SoCs Richard Hughes
2024-06-07 11:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29a975a-cb63-43cb-a421-8d7dd5ca36a6@amd.com \
--to=mario.limonciello@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=hughsient@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox