[PATCH] crypto: testmgr - drop unused static const arrays

[PATCH] crypto: testmgr - drop unused static const arrays

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The ones[] and zeroes[] definitions were previously used by the
rocksoft tests that are now gone. With extra warnings enabled,
gcc now complains about these:

crypto/testmgr.h:6021:17: error: 'ones' defined but not used [-Werror=unused-const-variable=]
 6021 | static const u8 ones[4096] = { [0 ... 4095] = 0xff };
      |                 ^~~~
crypto/testmgr.h:6020:17: error: 'zeroes' defined but not used [-Werror=unused-const-variable=]
 6020 | static const u8 zeroes[4096] = { [0 ... 4095] = 0 };
      |                 ^~~~~~

Drop them as well.

Fixes: dad9cb81bc30 ("crypto: crc64-rocksoft - remove from crypto API")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 crypto/testmgr.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/crypto/testmgr.h b/crypto/testmgr.h
index 4ab05046b734..61c7ae731052 100644
--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -6017,9 +6017,6 @@ static const struct hash_testvec rmd160_tv_template[] = {
 	}
 };
 
-static const u8 zeroes[4096] = { [0 ... 4095] = 0 };
-static const u8 ones[4096] = { [0 ... 4095] = 0xff };
-
 static const struct hash_testvec crct10dif_tv_template[] = {
 	{
 		.plaintext	= "abc",
-- 
2.39.5

Re: [PATCH] crypto: testmgr - drop unused static const arrays

[Eric Biggers]

On Wed, Feb 05, 2025 at 01:13:15PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The ones[] and zeroes[] definitions were previously used by the
> rocksoft tests that are now gone. With extra warnings enabled,
> gcc now complains about these:
> 
> crypto/testmgr.h:6021:17: error: 'ones' defined but not used [-Werror=unused-const-variable=]
>  6021 | static const u8 ones[4096] = { [0 ... 4095] = 0xff };
>       |                 ^~~~
> crypto/testmgr.h:6020:17: error: 'zeroes' defined but not used [-Werror=unused-const-variable=]
>  6020 | static const u8 zeroes[4096] = { [0 ... 4095] = 0 };
>       |                 ^~~~~~
> 
> Drop them as well.
> 
> Fixes: dad9cb81bc30 ("crypto: crc64-rocksoft - remove from crypto API")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  crypto/testmgr.h | 3 ---
>  1 file changed, 3 deletions(-)
> 

Thanks!  You must have tested today's linux-next.  The fixed commit is from one
of the patches of the series
https://lore.kernel.org/r/20250204195456.GA1385@sol.localdomain which I applied
to the crc tree yesterday.  I've folded in this fix, so it should be fixed in
tomorrow's linux-next.

Would be nice if these warnings were just on by default.

- Eric