Re: [v3 PATCH] crypto: scatterwalk - Add memcpy_sglist

[kernel test robot <lkp@intel.com>]

Hi Herbert,

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on next-20250306]
[cannot apply to linus/master v6.14-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-scatterwalk-Add-memcpy_sglist/20250306-113457
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/Z8kXhLb681E_FLzs%40gondor.apana.org.au
patch subject: [v3 PATCH] crypto: scatterwalk - Add memcpy_sglist
config: i386-buildonly-randconfig-002-20250307 (https://download.01.org/0day-ci/archive/20250307/202503071218.9J2sUblV-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250307/202503071218.9J2sUblV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503071218.9J2sUblV-lkp@intel.com/

All errors (new ones prefixed by >>):

>> crypto/scatterwalk.c:107:41: error: too few arguments to function call, expected 3, have 2
     107 |                 slen = scatterwalk_next(&swalk, nbytes);
         |                        ~~~~~~~~~~~~~~~~               ^
   include/crypto/scatterwalk.h:129:21: note: 'scatterwalk_next' declared here
     129 | static inline void *scatterwalk_next(struct scatter_walk *walk,
         |                     ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~
     130 |                                      unsigned int total,
         |                                      ~~~~~~~~~~~~~~~~~~~
     131 |                                      unsigned int *nbytes_ret)
         |                                      ~~~~~~~~~~~~~~~~~~~~~~~~
   crypto/scatterwalk.c:108:41: error: too few arguments to function call, expected 3, have 2
     108 |                 dlen = scatterwalk_next(&dwalk, nbytes);
         |                        ~~~~~~~~~~~~~~~~               ^
   include/crypto/scatterwalk.h:129:21: note: 'scatterwalk_next' declared here
     129 | static inline void *scatterwalk_next(struct scatter_walk *walk,
         |                     ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~
     130 |                                      unsigned int total,
         |                                      ~~~~~~~~~~~~~~~~~~~
     131 |                                      unsigned int *nbytes_ret)
         |                                      ~~~~~~~~~~~~~~~~~~~~~~~~
>> crypto/scatterwalk.c:110:16: error: no member named 'addr' in 'struct scatter_walk'
     110 |                 memcpy(dwalk.addr, swalk.addr, len);
         |                        ~~~~~ ^
   arch/x86/include/asm/string_32.h:150:42: note: expanded from macro 'memcpy'
     150 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n)
         |                                          ^
   crypto/scatterwalk.c:110:28: error: no member named 'addr' in 'struct scatter_walk'
     110 |                 memcpy(dwalk.addr, swalk.addr, len);
         |                                    ~~~~~ ^
   arch/x86/include/asm/string_32.h:150:45: note: expanded from macro 'memcpy'
     150 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n)
         |                                             ^
   crypto/scatterwalk.c:111:35: error: too few arguments to function call, expected 3, have 2
     111 |                 scatterwalk_done_dst(&dwalk, len);
         |                 ~~~~~~~~~~~~~~~~~~~~            ^
   include/crypto/scatterwalk.h:174:20: note: 'scatterwalk_done_dst' declared here
     174 | static inline void scatterwalk_done_dst(struct scatter_walk *walk,
         |                    ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~
     175 |                                         void *vaddr, unsigned int nbytes)
         |                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   crypto/scatterwalk.c:112:35: error: too few arguments to function call, expected 3, have 2
     112 |                 scatterwalk_done_src(&swalk, len);
         |                 ~~~~~~~~~~~~~~~~~~~~            ^
   include/crypto/scatterwalk.h:158:20: note: 'scatterwalk_done_src' declared here
     158 | static inline void scatterwalk_done_src(struct scatter_walk *walk,
         |                    ^                    ~~~~~~~~~~~~~~~~~~~~~~~~~~
     159 |                                         const void *vaddr, unsigned int nbytes)
         |                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   6 errors generated.


vim +107 crypto/scatterwalk.c

    90	
    91	void memcpy_sglist(struct scatterlist *dst, struct scatterlist *src,
    92			   unsigned int nbytes)
    93	{
    94		struct scatter_walk swalk;
    95		struct scatter_walk dwalk;
    96	
    97		if (unlikely(nbytes == 0)) /* in case sg == NULL */
    98			return;
    99	
   100		scatterwalk_start(&swalk, src);
   101		scatterwalk_start(&dwalk, dst);
   102	
   103		do {
   104			unsigned int slen, dlen;
   105			unsigned int len;
   106	
 > 107			slen = scatterwalk_next(&swalk, nbytes);
   108			dlen = scatterwalk_next(&dwalk, nbytes);
   109			len = min(slen, dlen);
 > 110			memcpy(dwalk.addr, swalk.addr, len);
   111			scatterwalk_done_dst(&dwalk, len);
   112			scatterwalk_done_src(&swalk, len);
   113			nbytes -= len;
   114		} while (nbytes);
   115	}
   116	EXPORT_SYMBOL_GPL(memcpy_sglist);
   117	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki