From: Eric Biggers <ebiggers@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Danilo Krummrich" <dakr@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH] firmware_loader: use SHA-256 library API instead of crypto_shash API
Date: Tue, 29 Apr 2025 09:42:23 -0700 [thread overview]
Message-ID: <20250429164223.GB1743@sol.localdomain> (raw)
In-Reply-To: <2025042935-ethanol-remodeler-bf69@gregkh>
On Tue, Apr 29, 2025 at 07:54:42AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 28, 2025 at 12:09:09PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > This user of SHA-256 does not support any other algorithm, so the
> > crypto_shash abstraction provides no value. Just use the SHA-256
> > library API instead, which is much simpler and easier to use.
> >
> > Also take advantage of printk's built-in hex conversion using %*phN.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > This patch is targeting the firmware_loader tree for 6.16.
>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg, it looks like you normally take patches to this file. You can go ahead
and take it if you want. Thanks!
- Eric
next prev parent reply other threads:[~2025-04-29 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 19:09 [PATCH] firmware_loader: use SHA-256 library API instead of crypto_shash API Eric Biggers
2025-04-29 5:54 ` Greg Kroah-Hartman
2025-04-29 16:42 ` Eric Biggers [this message]
2025-04-30 20:08 ` Danilo Krummrich
2026-03-06 16:37 ` Youssef Samir
2026-03-06 21:20 ` Eric Biggers
2026-03-10 15:12 ` Youssef Samir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429164223.GB1743@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox