From: Greg KH <gregkh@linuxfoundation.org>
To: Chenghai Huang <huangchenghai2@huawei.com>
Cc: zhangfei.gao@linaro.org, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linuxarm@openeuler.org, fanghao11@huawei.com,
shenyang39@huawei.com, liulongfang@huawei.com,
qianweili@huawei.com
Subject: Re: [PATCH v2 2/4] uacce: fix isolate sysfs check condition
Date: Tue, 16 Sep 2025 17:15:26 +0200 [thread overview]
Message-ID: <2025091633-antacid-gluten-0a61@gregkh> (raw)
In-Reply-To: <20250916144811.1799687-3-huangchenghai2@huawei.com>
On Tue, Sep 16, 2025 at 10:48:09PM +0800, Chenghai Huang wrote:
> The uacce supports device isolation feature. If the driver
> implements the isolate_err_threshold_read and
> isolate_err_threshold_write callbacks, the uacce will create sysfs
> files. Users can read and configure isolation policies through
> sysfs. Currently, if either isolate_err_threshold_read or
> isolate_err_threshold_write callback exists, sysfs files are
> created.
>
> However, accessing a non-existent callback may cause a system panic.
Where is the callback happening that fails? Shouldn't that be checked
instead of doing this change?
> Therefore, sysfs files are only created when both
> isolate_err_threshold_read and isolate_err_threshold_write are
> present.
What if a device only has 1? That should still work properly?
And why not just create the file if it is going to be used, that is the
real solution here.
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-16 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 14:48 [PATCH v2 0/4] uacce: driver fixes for memory leaks and state management Chenghai Huang
2025-09-16 14:48 ` [PATCH v2 1/4] uacce: fix for cdev memory leak Chenghai Huang
2025-09-16 15:14 ` Greg KH
2025-09-17 9:56 ` huangchenghai
2025-09-17 10:18 ` Greg KH
2025-09-26 8:47 ` huangchenghai
2025-09-26 9:37 ` linwenkai (C)
2025-09-16 14:48 ` [PATCH v2 2/4] uacce: fix isolate sysfs check condition Chenghai Huang
2025-09-16 15:15 ` Greg KH [this message]
2025-09-17 9:54 ` huangchenghai
2025-09-16 14:48 ` [PATCH v2 3/4] uacce: implement mremap in uacce_vm_ops to return -EPERM Chenghai Huang
2025-09-16 14:48 ` [PATCH v2 4/4] uacce: ensure safe queue release with state management Chenghai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025091633-antacid-gluten-0a61@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=fanghao11@huawei.com \
--cc=huangchenghai2@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
--cc=shenyang39@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox