From: Chenghai Huang <huangchenghai2@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<fanghao11@huawei.com>, <liulongfang@huawei.com>,
<qianweili@huawei.com>, <wangzhou1@hisilicon.com>,
<yinzhushuai@huawei.com>
Subject: [PATCH 2/5] crypto: hisilicon/qm - add const qualifier to info_name in struct qm_cmd_dump_item
Date: Mon, 30 Mar 2026 14:25:28 +0800 [thread overview]
Message-ID: <20260330062531.2976138-3-huangchenghai2@huawei.com> (raw)
In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com>
The "info_name" is never changed in struct qm_cmd_dump_item,
make it const.
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
drivers/crypto/hisilicon/debugfs.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c
index e5878558dc64..3ee6de16e3f1 100644
--- a/drivers/crypto/hisilicon/debugfs.c
+++ b/drivers/crypto/hisilicon/debugfs.c
@@ -45,8 +45,8 @@ struct qm_dfx_item {
struct qm_cmd_dump_item {
const char *cmd;
- char *info_name;
- int (*dump_fn)(struct hisi_qm *qm, char *cmd, char *info_name);
+ const char *info_name;
+ int (*dump_fn)(struct hisi_qm *qm, char *cmd, const char *info_name);
};
static struct qm_dfx_item qm_dfx_files[] = {
@@ -151,7 +151,7 @@ static ssize_t qm_cmd_read(struct file *filp, char __user *buffer,
}
static void dump_show(struct hisi_qm *qm, void *info,
- unsigned int info_size, char *info_name)
+ unsigned int info_size, const char *info_name)
{
struct device *dev = &qm->pdev->dev;
u8 *info_curr = info;
@@ -165,7 +165,7 @@ static void dump_show(struct hisi_qm *qm, void *info,
}
}
-static int qm_sqc_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_sqc_dump(struct hisi_qm *qm, char *s, const char *name)
{
struct device *dev = &qm->pdev->dev;
struct qm_sqc sqc;
@@ -202,7 +202,7 @@ static int qm_sqc_dump(struct hisi_qm *qm, char *s, char *name)
return 0;
}
-static int qm_cqc_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_cqc_dump(struct hisi_qm *qm, char *s, const char *name)
{
struct device *dev = &qm->pdev->dev;
struct qm_cqc cqc;
@@ -239,7 +239,7 @@ static int qm_cqc_dump(struct hisi_qm *qm, char *s, char *name)
return 0;
}
-static int qm_eqc_aeqc_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_eqc_aeqc_dump(struct hisi_qm *qm, char *s, const char *name)
{
struct device *dev = &qm->pdev->dev;
struct qm_aeqc aeqc;
@@ -317,7 +317,7 @@ static int q_dump_param_parse(struct hisi_qm *qm, char *s,
return 0;
}
-static int qm_sq_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_sq_dump(struct hisi_qm *qm, char *s, const char *name)
{
u16 sq_depth = qm->qp_array->sq_depth;
struct hisi_qp *qp;
@@ -345,7 +345,7 @@ static int qm_sq_dump(struct hisi_qm *qm, char *s, char *name)
return 0;
}
-static int qm_cq_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_cq_dump(struct hisi_qm *qm, char *s, const char *name)
{
struct qm_cqe *cqe_curr;
struct hisi_qp *qp;
@@ -363,7 +363,7 @@ static int qm_cq_dump(struct hisi_qm *qm, char *s, char *name)
return 0;
}
-static int qm_eq_aeq_dump(struct hisi_qm *qm, char *s, char *name)
+static int qm_eq_aeq_dump(struct hisi_qm *qm, char *s, const char *name)
{
struct device *dev = &qm->pdev->dev;
u16 xeq_depth;
--
2.33.0
next prev parent reply other threads:[~2026-03-30 6:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 6:25 [PATCH 0/5] crypto: hisilicon - series of cleanups and format fixes for hisilicon driver Chenghai Huang
2026-03-30 6:25 ` [PATCH 1/5] crypto: hisilicon - fix the format string type error Chenghai Huang
2026-03-30 6:25 ` Chenghai Huang [this message]
2026-03-30 6:25 ` [PATCH 3/5] crypto: hisilicon/qm - remove else after return Chenghai Huang
2026-03-30 6:25 ` [PATCH 4/5] crypto: hisilicon/qm - drop redundant variable initialization Chenghai Huang
2026-03-30 6:25 ` [PATCH 5/5] crypto: hisilicon - remove unused and non-public APIs for qm and sec Chenghai Huang
2026-04-08 8:07 ` [PATCH 0/5] crypto: hisilicon - series of cleanups and format fixes for hisilicon driver liulongfang
2026-04-12 8:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330062531.2976138-3-huangchenghai2@huawei.com \
--to=huangchenghai2@huawei.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yinzhushuai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox