From: Chenghai Huang <huangchenghai2@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<fanghao11@huawei.com>, <liulongfang@huawei.com>,
<qianweili@huawei.com>, <wangzhou1@hisilicon.com>,
<yinzhushuai@huawei.com>
Subject: [PATCH 4/5] crypto: hisilicon/qm - drop redundant variable initialization
Date: Mon, 30 Mar 2026 14:25:30 +0800 [thread overview]
Message-ID: <20260330062531.2976138-5-huangchenghai2@huawei.com> (raw)
In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com>
Variables are assigned before used. Initialization is not required.
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
drivers/crypto/hisilicon/qm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 0588355920dd..2bb51d4d88a6 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -3381,7 +3381,7 @@ static int __hisi_qm_start(struct hisi_qm *qm)
int hisi_qm_start(struct hisi_qm *qm)
{
struct device *dev = &qm->pdev->dev;
- int ret = 0;
+ int ret;
down_write(&qm->qps_lock);
@@ -3917,8 +3917,8 @@ static int qm_func_shaper_enable(struct hisi_qm *qm, u32 fun_index, u32 qos)
static u32 qm_get_shaper_vft_qos(struct hisi_qm *qm, u32 fun_index)
{
- u64 cir_u = 0, cir_b = 0, cir_s = 0;
u64 shaper_vft, ir_calc, ir;
+ u64 cir_u, cir_b, cir_s;
unsigned int val;
u32 error_rate;
int ret;
--
2.33.0
next prev parent reply other threads:[~2026-03-30 6:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 6:25 [PATCH 0/5] crypto: hisilicon - series of cleanups and format fixes for hisilicon driver Chenghai Huang
2026-03-30 6:25 ` [PATCH 1/5] crypto: hisilicon - fix the format string type error Chenghai Huang
2026-03-30 6:25 ` [PATCH 2/5] crypto: hisilicon/qm - add const qualifier to info_name in struct qm_cmd_dump_item Chenghai Huang
2026-03-30 6:25 ` [PATCH 3/5] crypto: hisilicon/qm - remove else after return Chenghai Huang
2026-03-30 6:25 ` Chenghai Huang [this message]
2026-03-30 6:25 ` [PATCH 5/5] crypto: hisilicon - remove unused and non-public APIs for qm and sec Chenghai Huang
2026-04-08 8:07 ` [PATCH 0/5] crypto: hisilicon - series of cleanups and format fixes for hisilicon driver liulongfang
2026-04-12 8:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330062531.2976138-5-huangchenghai2@huawei.com \
--to=huangchenghai2@huawei.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yinzhushuai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox