* [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations @ 2026-05-11 0:49 Chenghai Huang 2026-05-20 1:22 ` liulongfang 2026-05-22 12:27 ` Herbert Xu 0 siblings, 2 replies; 5+ messages in thread From: Chenghai Huang @ 2026-05-11 0:49 UTC (permalink / raw) To: herbert, davem Cc: linux-kernel, linux-crypto, fanghao11, liulongfang, qianweili, wangzhou1 From: lizhi <lizhi206@huawei.com> Lower the priority of HiSilicon's crypto implementations to allow more suitable alternatives to be selected. For example, certain kernel use-cases do not benefit from HiSilicon's symmetric crypto algorithms. This change ensures that more appropriate options are chosen first while retaining HiSilicon's implementations as alternatives. Signed-off-by: lizhi <lizhi206@huawei.com> Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> --- drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c index 2471a4dd0b50..77e0e03cbcab 100644 --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c @@ -20,7 +20,7 @@ #include "sec.h" #include "sec_crypto.h" -#define SEC_PRIORITY 4001 +#define SEC_PRIORITY 80 #define SEC_XTS_MIN_KEY_SIZE (2 * AES_MIN_KEY_SIZE) #define SEC_XTS_MID_KEY_SIZE (3 * AES_MIN_KEY_SIZE) #define SEC_XTS_MAX_KEY_SIZE (2 * AES_MAX_KEY_SIZE) -- 2.33.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations 2026-05-11 0:49 [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations Chenghai Huang @ 2026-05-20 1:22 ` liulongfang 2026-05-20 1:32 ` Eric Biggers 2026-05-22 12:27 ` Herbert Xu 1 sibling, 1 reply; 5+ messages in thread From: liulongfang @ 2026-05-20 1:22 UTC (permalink / raw) To: Chenghai Huang, herbert, davem Cc: linux-kernel, linux-crypto, fanghao11, qianweili, wangzhou1 On 2026/5/11 8:49, Chenghai Huang wrote: > From: lizhi <lizhi206@huawei.com> > > Lower the priority of HiSilicon's crypto implementations to allow more > suitable alternatives to be selected. For example, certain kernel > use-cases do not benefit from HiSilicon's symmetric crypto algorithms. > This change ensures that more appropriate options are chosen first while > retaining HiSilicon's implementations as alternatives. > > Signed-off-by: lizhi <lizhi206@huawei.com> > Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> > --- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c > index 2471a4dd0b50..77e0e03cbcab 100644 > --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c > +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c > @@ -20,7 +20,7 @@ > #include "sec.h" > #include "sec_crypto.h" > > -#define SEC_PRIORITY 4001 > +#define SEC_PRIORITY 80 > #define SEC_XTS_MIN_KEY_SIZE (2 * AES_MIN_KEY_SIZE) > #define SEC_XTS_MID_KEY_SIZE (3 * AES_MIN_KEY_SIZE) > #define SEC_XTS_MAX_KEY_SIZE (2 * AES_MAX_KEY_SIZE) > Reviewed-by: Longfang Liu <liulongfang@huawei.com> Thanks Longfang. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations 2026-05-20 1:22 ` liulongfang @ 2026-05-20 1:32 ` Eric Biggers 2026-05-20 9:27 ` huangchenghai 0 siblings, 1 reply; 5+ messages in thread From: Eric Biggers @ 2026-05-20 1:32 UTC (permalink / raw) To: liulongfang Cc: Chenghai Huang, herbert, davem, linux-kernel, linux-crypto, fanghao11, qianweili, wangzhou1 On Wed, May 20, 2026 at 09:22:49AM +0800, liulongfang wrote: > On 2026/5/11 8:49, Chenghai Huang wrote: > > From: lizhi <lizhi206@huawei.com> > > > > Lower the priority of HiSilicon's crypto implementations to allow more > > suitable alternatives to be selected. For example, certain kernel > > use-cases do not benefit from HiSilicon's symmetric crypto algorithms. > > This change ensures that more appropriate options are chosen first while > > retaining HiSilicon's implementations as alternatives. > > > > Signed-off-by: lizhi <lizhi206@huawei.com> > > Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> > > --- > > drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c > > index 2471a4dd0b50..77e0e03cbcab 100644 > > --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c > > +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c > > @@ -20,7 +20,7 @@ > > #include "sec.h" > > #include "sec_crypto.h" > > > > -#define SEC_PRIORITY 4001 > > +#define SEC_PRIORITY 80 > > #define SEC_XTS_MIN_KEY_SIZE (2 * AES_MIN_KEY_SIZE) > > #define SEC_XTS_MID_KEY_SIZE (3 * AES_MIN_KEY_SIZE) > > #define SEC_XTS_MAX_KEY_SIZE (2 * AES_MAX_KEY_SIZE) > > > > Reviewed-by: Longfang Liu <liulongfang@huawei.com> Makes sense, but perhaps this driver should just be removed entirely? - Eric ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations 2026-05-20 1:32 ` Eric Biggers @ 2026-05-20 9:27 ` huangchenghai 0 siblings, 0 replies; 5+ messages in thread From: huangchenghai @ 2026-05-20 9:27 UTC (permalink / raw) To: Eric Biggers, liulongfang Cc: herbert, davem, linux-kernel, linux-crypto, fanghao11, qianweili, wangzhou1 在 2026/5/20 9:32, Eric Biggers 写道: > On Wed, May 20, 2026 at 09:22:49AM +0800, liulongfang wrote: >> On 2026/5/11 8:49, Chenghai Huang wrote: >>> From: lizhi <lizhi206@huawei.com> >>> >>> Lower the priority of HiSilicon's crypto implementations to allow more >>> suitable alternatives to be selected. For example, certain kernel >>> use-cases do not benefit from HiSilicon's symmetric crypto algorithms. >>> This change ensures that more appropriate options are chosen first while >>> retaining HiSilicon's implementations as alternatives. >>> >>> Signed-off-by: lizhi <lizhi206@huawei.com> >>> Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> >>> --- >>> drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c >>> index 2471a4dd0b50..77e0e03cbcab 100644 >>> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c >>> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c >>> @@ -20,7 +20,7 @@ >>> #include "sec.h" >>> #include "sec_crypto.h" >>> >>> -#define SEC_PRIORITY 4001 >>> +#define SEC_PRIORITY 80 >>> #define SEC_XTS_MIN_KEY_SIZE (2 * AES_MIN_KEY_SIZE) >>> #define SEC_XTS_MID_KEY_SIZE (3 * AES_MIN_KEY_SIZE) >>> #define SEC_XTS_MAX_KEY_SIZE (2 * AES_MAX_KEY_SIZE) >>> >> Reviewed-by: Longfang Liu <liulongfang@huawei.com> > Makes sense, but perhaps this driver should just be removed entirely? > > - Eric > Hi Eric, Thanks for the review. We still have use cases to keep the driver. 1.Lowering the priority frees up hardware acceleration resources for targeted commercial use cases like storage encryption. 2.On old version of Kunpeng storage server, crypto instruction extensions may not be available, or the supported algorithm sets are limited. In these environments, users still use the HiSilicon hardware accelerator for encryption. Completely removing the driver would break support for those deployments. 3.Make the driver an optional backup, like QAT. Best regards, Chenghai ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations 2026-05-11 0:49 [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations Chenghai Huang 2026-05-20 1:22 ` liulongfang @ 2026-05-22 12:27 ` Herbert Xu 1 sibling, 0 replies; 5+ messages in thread From: Herbert Xu @ 2026-05-22 12:27 UTC (permalink / raw) To: Chenghai Huang Cc: davem, linux-kernel, linux-crypto, fanghao11, liulongfang, qianweili, wangzhou1 On Mon, May 11, 2026 at 08:49:27AM +0800, Chenghai Huang wrote: > From: lizhi <lizhi206@huawei.com> > > Lower the priority of HiSilicon's crypto implementations to allow more > suitable alternatives to be selected. For example, certain kernel > use-cases do not benefit from HiSilicon's symmetric crypto algorithms. > This change ensures that more appropriate options are chosen first while > retaining HiSilicon's implementations as alternatives. > > Signed-off-by: lizhi <lizhi206@huawei.com> > Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> > --- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-22 12:27 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-11 0:49 [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations Chenghai Huang 2026-05-20 1:22 ` liulongfang 2026-05-20 1:32 ` Eric Biggers 2026-05-20 9:27 ` huangchenghai 2026-05-22 12:27 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox