* [PATCH] crypto: cesa: add missing free_irq() calls
@ 2026-06-28 23:20 Rosen Penev
0 siblings, 0 replies; only message in thread
From: Rosen Penev @ 2026-06-28 23:20 UTC (permalink / raw)
To: linux-crypto
Cc: Srujana Challa, Bharat Bhushan, Herbert Xu, David S. Miller,
open list
Add the missing free_irq() calls, along with irq_set_affinity_hint(NULL)
to clear the affinity hint set during probe.
Fixes: 5bbf25419f8e ("crypto: marvell/cesa - use request_threaded_irq instead of devm variant")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/crypto/marvell/cesa/cesa.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/cesa/cesa.c
index 75d8ba23d9a2..57c9295be711 100644
--- a/drivers/crypto/marvell/cesa/cesa.c
+++ b/drivers/crypto/marvell/cesa/cesa.c
@@ -511,7 +511,7 @@ static int mv_cesa_probe(struct platform_device *pdev)
writel(engine->sram_dma & CESA_SA_SRAM_MSK,
engine->regs + CESA_SA_DESC_P0);
- ret = devm_request_threaded_irq(dev, irq, NULL, mv_cesa_int,
+ ret = request_threaded_irq(irq, NULL, mv_cesa_int,
IRQF_ONESHOT,
dev_name(&pdev->dev),
engine);
@@ -540,6 +540,10 @@ static int mv_cesa_probe(struct platform_device *pdev)
return 0;
err_cleanup:
+ while (i--) {
+ irq_set_affinity_hint(cesa->engines[i].irq, NULL);
+ free_irq(cesa->engines[i].irq, &cesa->engines[i]);
+ }
for (i = 0; i < caps->nengines; i++)
mv_cesa_put_sram(pdev, i);
@@ -553,8 +557,13 @@ static void mv_cesa_remove(struct platform_device *pdev)
mv_cesa_remove_algs(cesa);
- for (i = 0; i < cesa->caps->nengines; i++)
+ for (i = 0; i < cesa->caps->nengines; i++) {
+ struct mv_cesa_engine *engine = &cesa->engines[i];
+
+ irq_set_affinity_hint(engine->irq, NULL);
+ free_irq(engine->irq, engine);
mv_cesa_put_sram(pdev, i);
+ }
}
static const struct platform_device_id mv_cesa_plat_id_table[] = {
--
2.54.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-28 23:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-28 23:20 [PATCH] crypto: cesa: add missing free_irq() calls Rosen Penev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox