Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: herbert@gondor.apana.org.au, ebiggers@kernel.org
Cc: "Sasha Levin" <sashal@kernel.org>,
	linux-crypto@vger.kernel.org, stable@vger.kernel.org,
	"Muhammet Kaan KILINÇ" <muhammetkaankilinc@gmail.com>
Subject: Re: [PATCH v2 1/2] crypto: algif_skcipher - snapshot IV for async skcipher requests
Date: Sun, 12 Jul 2026 16:27:39 -0400	[thread overview]
Message-ID: <20260712105304.agent5-0003@kernel.org> (raw)
In-Reply-To: <20260712022618.1665-2-muhammetkaankilinc@gmail.com>

> MSG_MORE chunked chaining is unaffected: it is carried by ctx->state via
> crypto_skcipher_export()/import(), independent of the IV snapshot.

This isn't true for cbc/ctr: their statesize is 0, so export/import carry
nothing. The chained IV propagates only through the req->iv writeback, which
this patch redirects into the freed snapshot - AIO + MSG_MORE cbc/ctr silently
produces wrong output.

-- 
Thanks,
Sasha

  reply	other threads:[~2026-07-12 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05 22:01 [PATCH 0/2] crypto: algif_skcipher - fix AIO IV race in stable trees Muhammet Kaan KILINÇ
2026-07-05 22:01 ` [PATCH 1/2] crypto: algif_skcipher - snapshot IV for async skcipher requests Muhammet Kaan KILINÇ
2026-07-06 14:08   ` Sasha Levin
2026-07-12  2:43     ` Muhammet Kaan Kılınç
2026-07-05 22:01 ` [PATCH 2/2] crypto: algif_skcipher - force synchronous processing on trees without ctx->state Muhammet Kaan KILINÇ
2026-07-12  2:26 ` [PATCH v2 0/2] crypto: algif_skcipher - fix AIO IV race in stable trees Muhammet Kaan KILINÇ
2026-07-12  2:26   ` [PATCH v2 1/2] crypto: algif_skcipher - snapshot IV for async skcipher requests Muhammet Kaan KILINÇ
2026-07-12 20:27     ` Sasha Levin [this message]
2026-07-12  2:26   ` [PATCH v2 2/2] crypto: algif_skcipher - force synchronous processing on trees without ctx->state Muhammet Kaan KILINÇ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260712105304.agent5-0003@kernel.org \
    --to=sashal@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=muhammetkaankilinc@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox