[PATCH] lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection

[PATCH] lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection

[Eric Biggers]

Move the selection of CRYPTO_LIB_GF128HASH from CRYPTO_LIB_AES_GCM to
CRYPTO_LIB_AES to avoid a build error when CRYPTO_LIB_AES=y &&
CRYPTO_LIB_AES_GCM=m.  Like the other AES modes, AES-GCM is included in
libaes as an optional feature rather than a dedicated module.

Fixes: 2bbb64399435 ("lib/crypto: aes: Add GCM support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607220918.2RL0wGGS-lkp@intel.com/
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
 lib/crypto/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig
index 65a478f69715d..18cc911f79df6 100644
--- a/lib/crypto/Kconfig
+++ b/lib/crypto/Kconfig
@@ -8,6 +8,8 @@ config CRYPTO_LIB_UTILS
 
 config CRYPTO_LIB_AES
 	tristate
+	# Select dependencies of modes that are part of libaes.
+	select CRYPTO_LIB_GF128HASH if CRYPTO_LIB_AES_GCM != n
 	select CRYPTO_LIB_UTILS
 
 config CRYPTO_LIB_AES_ARCH
@@ -65,7 +67,6 @@ config CRYPTO_LIB_AES_GCM
 	tristate
 	select CRYPTO_LIB_AES
 	select CRYPTO_LIB_AES_CTR
-	select CRYPTO_LIB_GF128HASH
 	help
 	  The AES-GCM library functions.
 

base-commit: e4f23159c8d09b6b15d47f2c95e0a3e7c62f52a2
-- 
2.55.0

Re: [PATCH] lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection

[Eric Biggers]

On Tue, Jul 21, 2026 at 07:17:30PM -0700, Eric Biggers wrote:
> Move the selection of CRYPTO_LIB_GF128HASH from CRYPTO_LIB_AES_GCM to
> CRYPTO_LIB_AES to avoid a build error when CRYPTO_LIB_AES=y &&
> CRYPTO_LIB_AES_GCM=m.  Like the other AES modes, AES-GCM is included in
> libaes as an optional feature rather than a dedicated module.
> 
> Fixes: 2bbb64399435 ("lib/crypto: aes: Add GCM support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202607220918.2RL0wGGS-lkp@intel.com/
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>

I folded this into the fixed commit to eliminate the bisection hazard.

- Eric