* Non-existing CONFIG_ options are used in source code
@ 2023-09-13 9:29 sunying
2023-11-14 4:52 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: sunying @ 2023-09-13 9:29 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-crypto, pengpeng@iscas.ac.cn, renyanjie01@gmail.com
The following configuration options are not defined
(they may have been deleted or not yet added)
but are used in the source files.
Is there something in these that might need fixing?
===============================================
1. CONFIG_NETFS_DEBUG
fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
2. CONFIG_SSB_DEBUG
include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
===============================================
Best regards,
Yanjie Ren
Ying Sun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Non-existing CONFIG_ options are used in source code
2023-09-13 9:29 Non-existing CONFIG_ options are used in source code sunying
@ 2023-11-14 4:52 ` Randy Dunlap
2023-12-01 17:51 ` Michael Büsch
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-11-14 4:52 UTC (permalink / raw)
To: sunying, linux-kernel, Neal Liu, David Howells,
Michael Büsch
Cc: linux-crypto, pengpeng@iscas.ac.cn, renyanjie01@gmail.com
On 9/13/23 02:29, sunying@isrc.iscas.ac.cn wrote:
> The following configuration options are not defined
> (they may have been deleted or not yet added)
> but are used in the source files.
>
> Is there something in these that might need fixing?
>
> ===============================================
> 1. CONFIG_NETFS_DEBUG
> fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
>
> 2. CONFIG_SSB_DEBUG
> include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
>
> 3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> ===============================================
Yes, please send separate patches to remove each of them.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Non-existing CONFIG_ options are used in source code
2023-11-14 4:52 ` Randy Dunlap
@ 2023-12-01 17:51 ` Michael Büsch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2023-12-01 17:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: sunying, linux-kernel, Neal Liu, David Howells, linux-crypto,
pengpeng@iscas.ac.cn, renyanjie01@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Mon, 13 Nov 2023 20:52:03 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 9/13/23 02:29, sunying@isrc.iscas.ac.cn wrote:
> > The following configuration options are not defined
> > (they may have been deleted or not yet added)
> > but are used in the source files.
> >
> > Is there something in these that might need fixing?
> >
> > ===============================================
> > 1. CONFIG_NETFS_DEBUG
> > fs/netfs/internal.h:122:#elif defined(CONFIG_NETFS_DEBUG)
> >
> > 2. CONFIG_SSB_DEBUG
> > include/linux/ssb/ssb.h:626:#ifdef CONFIG_SSB_DEBUG
> >
> > 3. CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > drivers/crypto/aspeed/aspeed-hace-crypto.c:19:#ifdef
> > CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO_DEBUG
> > ===============================================
>
> Yes, please send separate patches to remove each of them.
I agree for CONFIG_SSB_DEBUG.
The function __ssb_dma_not_implemented() where CONFIG_SSB_DEBUG is used
can be removed and the switch-default where __ssb_dma_not_implemented()
is called can also be removed.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-01 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 9:29 Non-existing CONFIG_ options are used in source code sunying
2023-11-14 4:52 ` Randy Dunlap
2023-12-01 17:51 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox