* [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper
@ 2012-11-13 1:52 Shan Wei
2012-11-13 7:27 ` Steffen Klassert
0 siblings, 1 reply; 3+ messages in thread
From: Shan Wei @ 2012-11-13 1:52 UTC (permalink / raw)
To: steffen.klassert, Kernel-Maillist, linux-crypto, cl, Shan Wei
From: Shan Wei <davidshan@tencent.com>
For bottom halves off, __this_cpu_read is better.
Signed-off-by: Shan Wei <davidshan@tencent.com>
Reviewed-by: Christoph Lameter <cl@linux.com>
---
no changes vs v4.
---
kernel/padata.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 89fe3d1..072f4ee 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -171,7 +171,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
{
int cpu, num_cpus;
unsigned int next_nr, next_index;
- struct padata_parallel_queue *queue, *next_queue;
+ struct padata_parallel_queue *next_queue;
struct padata_priv *padata;
struct padata_list *reorder;
@@ -204,8 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
goto out;
}
- queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
- if (queue->cpu_index == next_queue->cpu_index) {
+ if (__this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
padata = ERR_PTR(-ENODATA);
goto out;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper
2012-11-13 1:52 [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper Shan Wei
@ 2012-11-13 7:27 ` Steffen Klassert
2012-11-13 7:36 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Steffen Klassert @ 2012-11-13 7:27 UTC (permalink / raw)
To: Shan Wei, Herbert Xu; +Cc: Kernel-Maillist, linux-crypto, cl
On Tue, Nov 13, 2012 at 09:52:33AM +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
>
> For bottom halves off, __this_cpu_read is better.
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> Reviewed-by: Christoph Lameter <cl@linux.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Herbert, are you going to take this one?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper
2012-11-13 7:27 ` Steffen Klassert
@ 2012-11-13 7:36 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2012-11-13 7:36 UTC (permalink / raw)
To: Steffen Klassert; +Cc: Shan Wei, Kernel-Maillist, linux-crypto, cl
On Tue, Nov 13, 2012 at 08:27:03AM +0100, Steffen Klassert wrote:
> On Tue, Nov 13, 2012 at 09:52:33AM +0800, Shan Wei wrote:
> > From: Shan Wei <davidshan@tencent.com>
> >
> > For bottom halves off, __this_cpu_read is better.
> >
> > Signed-off-by: Shan Wei <davidshan@tencent.com>
> > Reviewed-by: Christoph Lameter <cl@linux.com>
>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
>
> Herbert, are you going to take this one?
Thanks Steffen, I'll apply his patch.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-13 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 1:52 [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper Shan Wei
2012-11-13 7:27 ` Steffen Klassert
2012-11-13 7:36 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox