* Re: [cryptodev:master 22/36] arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support
[not found] <50fb3f38.VIxxNsjMujPGjroT%fengguang.wu@intel.com>
@ 2013-01-20 0:55 ` Herbert Xu
2013-01-20 5:55 ` Alexander Boyko
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2013-01-20 0:55 UTC (permalink / raw)
To: kbuild test robot, Linux Crypto Mailing List; +Cc: Alexander Boyko
On Sun, Jan 20, 2013 at 08:50:00AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: d3f5188dfea70e7ea6570bd4bc9d6d7dbd431e39
> commit: 78c37d191dd6899d8c219fee597a17d6e3c5d288 [22/36] crypto: crc32 - add crc32 pclmulqdq implementation and wrappers for table implementation
> config: make ARCH=i386 allyesconfig
>
> All warnings:
>
> >> arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support [-Wcpp]
>
> vim +87 arch/x86/crypto/crc32-pclmul_asm.S
>
> 71 /*
> 72 * #define CRCPOLY_TRUE_LE_FULL 0x1DB710641LL
> 73 *
> 74 * Barrett Reduction constant (u64`) = u` = (x**64 / P(x))` = 0x1F7011641LL
> 75 * #define CONSTANT_RU 0x1F7011641LL
> 76 */
> 77 .Lconstant_RUpoly:
> 78 .octa 0x00000001F701164100000001DB710641
> 79
> 80 #define CONSTANT %xmm0
> 81
> 82 #ifdef __x86_64__
> 83 #define BUF %rdi
> 84 #define LEN %rsi
> 85 #define CRC %edx
> 86 #else
> > 87 #warning Using 32bit code support
Do we need this warning or can I kill it?
Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [cryptodev:master 22/36] arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support
2013-01-20 0:55 ` [cryptodev:master 22/36] arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support Herbert Xu
@ 2013-01-20 5:55 ` Alexander Boyko
2013-01-20 7:05 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Boyko @ 2013-01-20 5:55 UTC (permalink / raw)
To: Herbert Xu; +Cc: kbuild test robot, Linux Crypto Mailing List
You can kill it.
1/20/13 4:55 AM, Herbert Xu пишет:
> On Sun, Jan 20, 2013 at 08:50:00AM +0800, kbuild test robot wrote:
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
>> head: d3f5188dfea70e7ea6570bd4bc9d6d7dbd431e39
>> commit: 78c37d191dd6899d8c219fee597a17d6e3c5d288 [22/36] crypto: crc32 - add crc32 pclmulqdq implementation and wrappers for table implementation
>> config: make ARCH=i386 allyesconfig
>>
>> All warnings:
>>
>>>> arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support [-Wcpp]
>> vim +87 arch/x86/crypto/crc32-pclmul_asm.S
>>
>> 71 /*
>> 72 * #define CRCPOLY_TRUE_LE_FULL 0x1DB710641LL
>> 73 *
>> 74 * Barrett Reduction constant (u64`) = u` = (x**64 / P(x))` = 0x1F7011641LL
>> 75 * #define CONSTANT_RU 0x1F7011641LL
>> 76 */
>> 77 .Lconstant_RUpoly:
>> 78 .octa 0x00000001F701164100000001DB710641
>> 79
>> 80 #define CONSTANT %xmm0
>> 81
>> 82 #ifdef __x86_64__
>> 83 #define BUF %rdi
>> 84 #define LEN %rsi
>> 85 #define CRC %edx
>> 86 #else
>> > 87 #warning Using 32bit code support
> Do we need this warning or can I kill it?
>
> Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [cryptodev:master 22/36] arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support
2013-01-20 5:55 ` Alexander Boyko
@ 2013-01-20 7:05 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2013-01-20 7:05 UTC (permalink / raw)
To: Alexander Boyko; +Cc: kbuild test robot, Linux Crypto Mailing List
On Sun, Jan 20, 2013 at 09:55:37AM +0400, Alexander Boyko wrote:
> You can kill it.
OK.
commit 7983627657db5e37594af5c28cdb623855eb554f
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun Jan 20 18:05:02 2013 +1100
crypto: crc32-pclmul - Kill warning on x86-32
This patch removes a gratuitous warning on x86-32:
arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support [-Wcpp]
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/arch/x86/crypto/crc32-pclmul_asm.S b/arch/x86/crypto/crc32-pclmul_asm.S
index 65ea6a6..c8335014 100644
--- a/arch/x86/crypto/crc32-pclmul_asm.S
+++ b/arch/x86/crypto/crc32-pclmul_asm.S
@@ -84,7 +84,6 @@
#define LEN %rsi
#define CRC %edx
#else
-#warning Using 32bit code support
#define BUF %eax
#define LEN %edx
#define CRC %ecx
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-20 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50fb3f38.VIxxNsjMujPGjroT%fengguang.wu@intel.com>
2013-01-20 0:55 ` [cryptodev:master 22/36] arch/x86/crypto/crc32-pclmul_asm.S:87:2: warning: #warning Using 32bit code support Herbert Xu
2013-01-20 5:55 ` Alexander Boyko
2013-01-20 7:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox