Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: herbert@gondor.apana.org.au
Cc: Fengguang Wu <fengguang.wu@intel.com>, linux-crypto@vger.kernel.org
Subject: [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres
Date: Wed, 27 May 2015 13:50:12 +0200	[thread overview]
Message-ID: <5175461.r5Ln1vVEmU@tachyon.chronox.de> (raw)

The patch removes the use of timekeeping_valid_for_hres which is now
marked as internal for the time keeping subsystem. The jitterentropy
does not really require this verification as a coarse timer (when
random_get_entropy is absent) is discovered by the initialization test
of jent_entropy_init, which would cause the jitter rng to not load in
that case.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 crypto/jitterentropy.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/crypto/jitterentropy.c b/crypto/jitterentropy.c
index 1ebe58a..a60147e 100644
--- a/crypto/jitterentropy.c
+++ b/crypto/jitterentropy.c
@@ -131,9 +131,6 @@ static inline void jent_get_nstime(__u64 *out)
 	 * and are registered with clocksource_register()
 	 */
 	if ((0 == tmp) &&
-#ifndef MODULE
-	   (0 == timekeeping_valid_for_hres()) &&
-#endif
 	   (0 == __getnstimeofday(&ts))) {
 		tmp = ts.tv_sec;
 		tmp = tmp << 32;
-- 
2.1.0

             reply	other threads:[~2015-05-27 11:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 11:50 Stephan Mueller [this message]
2015-05-28  3:31 ` [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5175461.r5Ln1vVEmU@tachyon.chronox.de \
    --to=smueller@chronox.de \
    --cc=fengguang.wu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox