Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres
@ 2015-05-27 11:50 Stephan Mueller
  2015-05-28  3:31 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Stephan Mueller @ 2015-05-27 11:50 UTC (permalink / raw)
  To: herbert; +Cc: Fengguang Wu, linux-crypto

The patch removes the use of timekeeping_valid_for_hres which is now
marked as internal for the time keeping subsystem. The jitterentropy
does not really require this verification as a coarse timer (when
random_get_entropy is absent) is discovered by the initialization test
of jent_entropy_init, which would cause the jitter rng to not load in
that case.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 crypto/jitterentropy.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/crypto/jitterentropy.c b/crypto/jitterentropy.c
index 1ebe58a..a60147e 100644
--- a/crypto/jitterentropy.c
+++ b/crypto/jitterentropy.c
@@ -131,9 +131,6 @@ static inline void jent_get_nstime(__u64 *out)
 	 * and are registered with clocksource_register()
 	 */
 	if ((0 == tmp) &&
-#ifndef MODULE
-	   (0 == timekeeping_valid_for_hres()) &&
-#endif
 	   (0 == __getnstimeofday(&ts))) {
 		tmp = ts.tv_sec;
 		tmp = tmp << 32;
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres
  2015-05-27 11:50 [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres Stephan Mueller
@ 2015-05-28  3:31 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-05-28  3:31 UTC (permalink / raw)
  To: Stephan Mueller; +Cc: Fengguang Wu, linux-crypto

On Wed, May 27, 2015 at 01:50:12PM +0200, Stephan Mueller wrote:
> The patch removes the use of timekeeping_valid_for_hres which is now
> marked as internal for the time keeping subsystem. The jitterentropy
> does not really require this verification as a coarse timer (when
> random_get_entropy is absent) is discovered by the initialization test
> of jent_entropy_init, which would cause the jitter rng to not load in
> that case.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>

Applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-28  3:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 11:50 [PATCH] crypto: jitterentropy - remove timekeeping_valid_for_hres Stephan Mueller
2015-05-28  3:31 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox