* [PATCH 2/2] crypto: s5p-sss: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:49 Jingoo Han
2013-05-09 22:32 ` Vladimir Zapolskiy
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 3:49 UTC (permalink / raw)
To: 'Herbert Xu'; +Cc: linux-crypto, 'David S. Miller', Jingoo Han
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/crypto/s5p-sss.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 4b31432..cf149b1 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -647,7 +647,6 @@ static int s5p_aes_probe(struct platform_device *pdev)
clk_disable(pdata->clk);
s5p_dev = NULL;
- platform_set_drvdata(pdev, NULL);
return err;
}
@@ -668,7 +667,6 @@ static int s5p_aes_remove(struct platform_device *pdev)
clk_disable(pdata->clk);
s5p_dev = NULL;
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] crypto: s5p-sss: remove unnecessary platform_set_drvdata()
2013-05-06 3:49 [PATCH 2/2] crypto: s5p-sss: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-09 22:32 ` Vladimir Zapolskiy
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Zapolskiy @ 2013-05-09 22:32 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Herbert Xu', linux-crypto, 'David S. Miller'
On 05/06/13 06:49, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
> drivers/crypto/s5p-sss.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 4b31432..cf149b1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -647,7 +647,6 @@ static int s5p_aes_probe(struct platform_device *pdev)
> clk_disable(pdata->clk);
>
> s5p_dev = NULL;
> - platform_set_drvdata(pdev, NULL);
>
> return err;
> }
> @@ -668,7 +667,6 @@ static int s5p_aes_remove(struct platform_device *pdev)
> clk_disable(pdata->clk);
>
> s5p_dev = NULL;
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-09 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 3:49 [PATCH 2/2] crypto: s5p-sss: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-09 22:32 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox