From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
herbert@gondor.apana.org.au, robh@kernel.org
Cc: Ruud.Derwig@synopsys.com, manjunath.hadli@vayavyalabs.com,
adityak@vayavyalabs.com,
Bhoomika Kadabi <bhoomikak@vayavyalabs.com>
Subject: Re: [PATCH v2 1/6] dt-bindings: crypto: Document support for SPAcc
Date: Mon, 5 May 2025 17:48:56 +0200 [thread overview]
Message-ID: <5b6c66e8-3fac-408f-980c-f261ccd3fefd@kernel.org> (raw)
In-Reply-To: <20250505125538.2991314-2-pavitrakumarm@vayavyalabs.com>
On 05/05/2025 14:55, Pavitrakumar M wrote:
> From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
>
> Add DT bindings related to the SPAcc driver for Documentation.
> DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto
> Engine is a crypto IP designed by Synopsys.
>
> Co-developed-by: Bhoomika Kadabi <bhoomikak@vayavyalabs.com>
> Signed-off-by: Bhoomika Kadabi <bhoomikak@vayavyalabs.com>
> Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
> Acked-by: Ruud Derwig <Ruud.Derwig@synopsys.com>
I do not see any improvements. It seems you ignored all comments, not
single one was responded to or addressed.
NAK
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-05 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 12:55 [PATCH v2 0/6] Add SPAcc Crypto Driver Pavitrakumar M
2025-05-05 12:55 ` [PATCH v2 1/6] dt-bindings: crypto: Document support for SPAcc Pavitrakumar M
2025-05-05 15:48 ` Krzysztof Kozlowski [this message]
2025-05-05 15:52 ` Krzysztof Kozlowski
2025-05-06 6:33 ` Pavitrakumar Managutte
2025-05-06 6:51 ` Krzysztof Kozlowski
2025-05-13 6:30 ` Pavitrakumar Managutte
2025-05-18 13:30 ` Krzysztof Kozlowski
2025-05-23 8:24 ` Pavitrakumar Managutte
2025-05-25 11:29 ` Krzysztof Kozlowski
2025-05-05 12:55 ` [PATCH v2 2/6] Add SPAcc Skcipher support Pavitrakumar M
2025-05-05 12:55 ` [PATCH v2 3/6] Add SPAcc AUTODETECT Support Pavitrakumar M
2025-05-05 12:55 ` [PATCH v2 4/6] Add SPAcc ahash support Pavitrakumar M
2025-05-12 5:31 ` Herbert Xu
2025-05-05 12:55 ` [PATCH v2 5/6] Add SPAcc AEAD support Pavitrakumar M
2025-05-05 12:55 ` [PATCH v2 6/6] Add SPAcc Kconfig and Makefile Pavitrakumar M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6c66e8-3fac-408f-980c-f261ccd3fefd@kernel.org \
--to=krzk@kernel.org \
--cc=Ruud.Derwig@synopsys.com \
--cc=adityak@vayavyalabs.com \
--cc=bhoomikak@vayavyalabs.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=manjunath.hadli@vayavyalabs.com \
--cc=pavitrakumarm@vayavyalabs.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox