* [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine
2026-04-06 2:09 [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support Alexander Koskovich
@ 2026-04-06 2:10 ` Alexander Koskovich
2026-04-06 8:45 ` Krzysztof Kozlowski
` (2 more replies)
2026-04-06 2:10 ` [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes Alexander Koskovich
2026-05-12 20:22 ` (subset) [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support Bjorn Andersson
2 siblings, 3 replies; 9+ messages in thread
From: Alexander Koskovich @ 2026-04-06 2:10 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel,
Alexander Koskovich
Document the crypto engine on the Milos platform.
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 79d5be2548bc..74a121d8b2a5 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -46,6 +46,7 @@ properties:
- items:
- enum:
- qcom,kaanapali-qce
+ - qcom,milos-qce
- qcom,qcs615-qce
- qcom,qcs8300-qce
- qcom,sa8775p-qce
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine
2026-04-06 2:10 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine Alexander Koskovich
@ 2026-04-06 8:45 ` Krzysztof Kozlowski
2026-04-06 8:59 ` Kuldeep Singh
2026-05-05 8:35 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-06 8:45 UTC (permalink / raw)
To: Alexander Koskovich
Cc: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
linux-crypto, linux-arm-msm, devicetree, linux-kernel
On Mon, Apr 06, 2026 at 02:10:07AM +0000, Alexander Koskovich wrote:
> Document the crypto engine on the Milos platform.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine
2026-04-06 2:10 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine Alexander Koskovich
2026-04-06 8:45 ` Krzysztof Kozlowski
@ 2026-04-06 8:59 ` Kuldeep Singh
2026-05-05 8:35 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Kuldeep Singh @ 2026-04-06 8:59 UTC (permalink / raw)
To: Alexander Koskovich, Thara Gopinath, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel
On 4/6/2026 7:40 AM, Alexander Koskovich wrote:
> Document the crypto engine on the Milos platform.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Reviewed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine
2026-04-06 2:10 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine Alexander Koskovich
2026-04-06 8:45 ` Krzysztof Kozlowski
2026-04-06 8:59 ` Kuldeep Singh
@ 2026-05-05 8:35 ` Herbert Xu
2 siblings, 0 replies; 9+ messages in thread
From: Herbert Xu @ 2026-05-05 8:35 UTC (permalink / raw)
To: Alexander Koskovich
Cc: Thara Gopinath, David S. Miller, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-crypto,
linux-arm-msm, devicetree, linux-kernel
On Mon, Apr 06, 2026 at 02:10:07AM +0000, Alexander Koskovich wrote:
> Document the crypto engine on the Milos platform.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes
2026-04-06 2:09 [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support Alexander Koskovich
2026-04-06 2:10 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine Alexander Koskovich
@ 2026-04-06 2:10 ` Alexander Koskovich
2026-04-08 10:05 ` Konrad Dybcio
2026-04-09 4:15 ` Kuldeep Singh
2026-05-12 20:22 ` (subset) [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support Bjorn Andersson
2 siblings, 2 replies; 9+ messages in thread
From: Alexander Koskovich @ 2026-04-06 2:10 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel,
Alexander Koskovich
Add the QCE and Crypto BAM DMA nodes.
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
arch/arm64/boot/dts/qcom/milos.dtsi | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
index e1a51d43943f..61418657c4e9 100644
--- a/arch/arm64/boot/dts/qcom/milos.dtsi
+++ b/arch/arm64/boot/dts/qcom/milos.dtsi
@@ -1151,6 +1151,38 @@ aggre2_noc: interconnect@1700000 {
qcom,bcm-voters = <&apps_bcm_voter>;
};
+ cryptobam: dma-controller@1dc4000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0x0 0x01dc4000 0x0 0x28000>;
+
+ interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH 0>;
+
+ #dma-cells = <1>;
+
+ iommus = <&apps_smmu 0x480 0>,
+ <&apps_smmu 0x481 0>;
+
+ qcom,ee = <0>;
+ qcom,num-ees = <4>;
+ num-channels = <20>;
+ qcom,controlled-remotely;
+ };
+
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,milos-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0x0 0x01dfa000 0x0 0x6000>;
+
+ interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "memory";
+
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+
+ iommus = <&apps_smmu 0x480 0>,
+ <&apps_smmu 0x481 0>;
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0x0 0x01f40000 0x0 0x20000>;
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes
2026-04-06 2:10 ` [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes Alexander Koskovich
@ 2026-04-08 10:05 ` Konrad Dybcio
2026-04-09 4:15 ` Kuldeep Singh
1 sibling, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-04-08 10:05 UTC (permalink / raw)
To: Alexander Koskovich, Thara Gopinath, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel
On 4/6/26 4:10 AM, Alexander Koskovich wrote:
> Add the QCE and Crypto BAM DMA nodes.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes
2026-04-06 2:10 ` [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes Alexander Koskovich
2026-04-08 10:05 ` Konrad Dybcio
@ 2026-04-09 4:15 ` Kuldeep Singh
1 sibling, 0 replies; 9+ messages in thread
From: Kuldeep Singh @ 2026-04-09 4:15 UTC (permalink / raw)
To: Alexander Koskovich, Thara Gopinath, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel
On 4/6/2026 7:40 AM, Alexander Koskovich wrote:
> Add the QCE and Crypto BAM DMA nodes.
>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Reviewed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support
2026-04-06 2:09 [PATCH 0/2] arm64: dts: qcom: milos: Add QCrypto support Alexander Koskovich
2026-04-06 2:10 ` [PATCH 1/2] dt-bindings: crypto: qcom-qce: Document the Milos crypto engine Alexander Koskovich
2026-04-06 2:10 ` [PATCH 2/2] arm64: dts: qcom: milos: Add QCrypto nodes Alexander Koskovich
@ 2026-05-12 20:22 ` Bjorn Andersson
2 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2026-05-12 20:22 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
Alexander Koskovich
Cc: linux-crypto, linux-arm-msm, devicetree, linux-kernel
On Mon, 06 Apr 2026 02:09:59 +0000, Alexander Koskovich wrote:
> Add the dt-bindings and device tree nodes for the Qualcomm Crypto
> Engine (QCE) and its associated BAM DMA controller on the Milos
> platform.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: milos: Add QCrypto nodes
commit: 208af18362e01f59bfe4a71a8606b09acb673cd0
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread