Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH] crypto: caam - Add missing Job Ring include
@ 2013-11-18  4:20 Michael Neuling
  2013-11-19  4:17 ` Ruchika Gupta
  2013-11-26  9:42 ` Ruchika Gupta
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Neuling @ 2013-11-18  4:20 UTC (permalink / raw)
  To: Ruchika Gupta; +Cc: Garg Vakul-B16394, Herbert Xu, linux-crypto, sfr

linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
giving:

  drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
  drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function 'of_iomap' [-Werror=implicit-function-declaration]

In:
  commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
  Author: Ruchika Gupta <ruchika.gupta@freescale.com>
  crypto: caam - Add Platform driver for Job Ring

We added a reference to of_iomap but did add the necessary include file.

The below adds this include.

Signed-off-by: Michael Neuling <mikey@neuling.org>

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index d23356d2..1d80bd3 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -6,6 +6,7 @@
  */
 
 #include <linux/of_irq.h>
+#include <linux/of_address.h>
 
 #include "compat.h"
 #include "regs.h"

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] crypto: caam - Add missing Job Ring include
  2013-11-18  4:20 [PATCH] crypto: caam - Add missing Job Ring include Michael Neuling
@ 2013-11-19  4:17 ` Ruchika Gupta
  2013-11-26 12:59   ` Herbert Xu
  2013-11-26  9:42 ` Ruchika Gupta
  1 sibling, 1 reply; 4+ messages in thread
From: Ruchika Gupta @ 2013-11-19  4:17 UTC (permalink / raw)
  To: Michael Neuling
  Cc: Vakul Garg, Herbert Xu, linux-crypto@vger.kernel.org,
	sfr@canb.auug.org.au

Acked-by: Ruchika Gupta <ruchika.gupta@freescale.com>

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto-
> owner@vger.kernel.org] On Behalf Of Michael Neuling
> Sent: Monday, November 18, 2013 9:50 AM
> To: Gupta Ruchika-R66431
> Cc: Garg Vakul-B16394; Herbert Xu; linux-crypto@vger.kernel.org;
> sfr@canb.auug.org.au
> Subject: [PATCH] crypto: caam - Add missing Job Ring include
> 
> linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> giving:
> 
>   drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
>   drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
> 
> In:
>   commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
>   Author: Ruchika Gupta <ruchika.gupta@freescale.com>
>   crypto: caam - Add Platform driver for Job Ring
> 
> We added a reference to of_iomap but did add the necessary include file.
> 
> The below adds this include.
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> 
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
>   */
> 
>  #include <linux/of_irq.h>
> +#include <linux/of_address.h>
> 
>  #include "compat.h"
>  #include "regs.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] crypto: caam - Add missing Job Ring include
  2013-11-18  4:20 [PATCH] crypto: caam - Add missing Job Ring include Michael Neuling
  2013-11-19  4:17 ` Ruchika Gupta
@ 2013-11-26  9:42 ` Ruchika Gupta
  1 sibling, 0 replies; 4+ messages in thread
From: Ruchika Gupta @ 2013-11-26  9:42 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Vakul Garg, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au,
	Ruchika Gupta, Michael Neuling

Hi Herbert,

Can you please apply this patch.

Regards,
Ruchika

> -----Original Message-----
> From: Gupta Ruchika-R66431
> Sent: Tuesday, November 19, 2013 9:47 AM
> To: 'Michael Neuling'
> Cc: Garg Vakul-B16394; Herbert Xu; linux-crypto@vger.kernel.org;
> sfr@canb.auug.org.au
> Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include
> 
> Acked-by: Ruchika Gupta <ruchika.gupta@freescale.com>
> 
> > -----Original Message-----
> > From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto-
> > owner@vger.kernel.org] On Behalf Of Michael Neuling
> > Sent: Monday, November 18, 2013 9:50 AM
> > To: Gupta Ruchika-R66431
> > Cc: Garg Vakul-B16394; Herbert Xu; linux-crypto@vger.kernel.org;
> > sfr@canb.auug.org.au
> > Subject: [PATCH] crypto: caam - Add missing Job Ring include
> >
> > linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> > giving:
> >
> >   drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> >   drivers/crypto/caam/jr.c:468:2: error: implicit declaration of
> > function 'of_iomap' [-Werror=implicit-function-declaration]
> >
> > In:
> >   commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
> >   Author: Ruchika Gupta <ruchika.gupta@freescale.com>
> >   crypto: caam - Add Platform driver for Job Ring
> >
> > We added a reference to of_iomap but did add the necessary include file.
> >
> > The below adds this include.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> >
> > diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> > d23356d2..1d80bd3 100644
> > --- a/drivers/crypto/caam/jr.c
> > +++ b/drivers/crypto/caam/jr.c
> > @@ -6,6 +6,7 @@
> >   */
> >
> >  #include <linux/of_irq.h>
> > +#include <linux/of_address.h>
> >
> >  #include "compat.h"
> >  #include "regs.h"
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-crypto" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: caam - Add missing Job Ring include
  2013-11-19  4:17 ` Ruchika Gupta
@ 2013-11-26 12:59   ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2013-11-26 12:59 UTC (permalink / raw)
  To: Ruchika Gupta
  Cc: Michael Neuling, Vakul Garg, linux-crypto@vger.kernel.org,
	sfr@canb.auug.org.au

On Tue, Nov 19, 2013 at 04:17:31AM +0000, Ruchika Gupta wrote:
> Acked-by: Ruchika Gupta <ruchika.gupta@freescale.com>

Patch applied to crypto.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-11-26 12:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-18  4:20 [PATCH] crypto: caam - Add missing Job Ring include Michael Neuling
2013-11-19  4:17 ` Ruchika Gupta
2013-11-26 12:59   ` Herbert Xu
2013-11-26  9:42 ` Ruchika Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox