Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	 Harald Freudenberger <freude@linux.ibm.com>,
	 Ingo Franzki <ifranzki@linux.ibm.com>,
	linux-crypto@vger.kernel.org,  Eric Biggers <ebiggers@kernel.org>,
	dengler@linux.ibm.com,  linux-s390@vger.kernel.org,
	dm-devel@lists.linux.dev, agk@redhat.com,  snitzer@kernel.org,
	Milan Broz <gmazyland@gmail.com>,
	guazhang@redhat.com
Subject: Re: [PATCH] crypto/authenc: don't return -EBUSY when enqueuing the hash request
Date: Tue, 25 Nov 2025 15:02:06 +0100 (CET)	[thread overview]
Message-ID: <7c1b844a-443e-9fd3-3aa9-0dacbc381812@redhat.com> (raw)
In-Reply-To: <aNK6IMzUgslPVi3x@gondor.apana.org.au>



On Tue, 23 Sep 2025, Herbert Xu wrote:

> On Tue, Sep 23, 2025 at 01:14:10PM +0200, Mikulas Patocka wrote:
> >
> > static void authenc_request_complete(struct aead_request *req, int err)
> > {
> >         if (err != -EINPROGRESS)
> >                 aead_request_complete(req, err);
> > }
> 
> Oh OK.  That was kind of a hack which worked because authenc was
> used by IPsec only, so it didn't expect to be called with MAY_BACKLOG.
> 
> Now that you're calling it with MAY_BACKLOG, we need to fix it to
> distinguish between an EINPROGRESS notification for EBUSY and one
> that's returned directly by an async function.
> 
> Thanks,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Hi Herbert

What's the status of this bugfix? I searched the git history, but didn't 
find it.

We have hit another deadlock in dm-crypt when using the "tegra-se" driver 
(the driver returned -EBUSY, but didn't call the completion routine with 
-EINPROGRESS), and I suspect that it may be this problem again.

Mikulas


  parent reply	other threads:[~2025-11-25 14:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250908131642.385445532@debian4.vm>
     [not found] ` <3a6b6f8f-5205-459c-810a-2425aae92fc8@linux.ibm.com>
     [not found]   ` <e1e420d5-dc00-14d0-fdef-635d6ef70811@redhat.com>
     [not found]     ` <bb68f9d6-8180-4291-9e6b-33bbdcef780f@linux.ibm.com>
     [not found]       ` <8cb59ed5-1c9a-49de-beee-01eda52ad618@linux.ibm.com>
     [not found]         ` <1af710ec-0f23-2522-d715-e683b9e557d8@redhat.com>
     [not found]           ` <f799d7ab97470f2529b8dcb5566fd673@linux.ibm.com>
2025-09-22 19:08             ` [PATCH] crypto/authenc: don't return -EBUSY when enqueuing the hash request Mikulas Patocka
2025-09-23  3:47               ` Herbert Xu
2025-09-23 11:14                 ` Mikulas Patocka
2025-09-23 14:36                   ` Mikulas Patocka
2025-09-23 15:17                   ` Herbert Xu
2025-09-24 10:20                     ` [PATCH] crypto: authenc - Correctly pass EINPROGRESS back up to the caller Herbert Xu
2025-09-24 13:17                       ` Ingo Franzki
2025-11-25 14:02                     ` Mikulas Patocka [this message]
2025-11-26  5:16                       ` [PATCH] crypto/authenc: don't return -EBUSY when enqueuing the hash request Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c1b844a-443e-9fd3-3aa9-0dacbc381812@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dengler@linux.ibm.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=ebiggers@kernel.org \
    --cc=freude@linux.ibm.com \
    --cc=gmazyland@gmail.com \
    --cc=guazhang@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=ifranzki@linux.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox