* ahash and crc32c
@ 2013-02-26 17:11 Zeev Zilberman
2016-10-28 12:46 ` Horia Geanta Neag
0 siblings, 1 reply; 2+ messages in thread
From: Zeev Zilberman @ 2013-02-26 17:11 UTC (permalink / raw)
To: linux-crypto@vger.kernel.org
Hi,
I'm working on an ahash driver that supports CRC32C.
I saw that all existing CRC32C implementations (except blackfin) are
implementing shash interface, but ahash seems to be the correct choice
in our case.
On the other hand I saw that CRC32C test in testmgr.c tries to create
shash tfm for CRC32C and assumes that the CRC context is saved in first
4 bytes of the shash context.
When I implement CRC32C algorithm this part of the test fails.
How should I treat this failure? What is the reason for the requirement
that is tested in this scenario?
Thank you.
Zeev.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ahash and crc32c
2013-02-26 17:11 ahash and crc32c Zeev Zilberman
@ 2016-10-28 12:46 ` Horia Geanta Neag
0 siblings, 0 replies; 2+ messages in thread
From: Horia Geanta Neag @ 2016-10-28 12:46 UTC (permalink / raw)
To: Zeev Zilberman, Herbert Xu; +Cc: linux-crypto@vger.kernel.org, David S. Miller
On 2/26/2013 7:11 PM, Zeev Zilberman wrote:
> Hi,
>
> I'm working on an ahash driver that supports CRC32C.
> I saw that all existing CRC32C implementations (except blackfin) are
> implementing shash interface, but ahash seems to be the correct choice
> in our case.
> On the other hand I saw that CRC32C test in testmgr.c tries to create
> shash tfm for CRC32C and assumes that the CRC context is saved in first
> 4 bytes of the shash context.
>
> When I implement CRC32C algorithm this part of the test fails.
>
> How should I treat this failure? What is the reason for the requirement
> that is tested in this scenario?
Same question here.
I've added a crc32c ahash implementation, and reverted commit:
8e3ee85e68c5d "crypto: crc32c - Test descriptor context format"
as a temporary workaround for the testmgr.c failure.
Thanks,
Horia
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-28 17:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 17:11 ahash and crc32c Zeev Zilberman
2016-10-28 12:46 ` Horia Geanta Neag
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox