From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Jason A . Donenfeld " <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: remove use_input_pool parameter from crng_reseed()
Date: Sat, 5 Feb 2022 08:22:50 +0100 [thread overview]
Message-ID: <Yf4lyqaPOxGoG8/q@owl.dominikbrodowski.net> (raw)
In-Reply-To: <20220204221733.39411-1-ebiggers@kernel.org>
Am Fri, Feb 04, 2022 at 02:17:33PM -0800 schrieb Eric Biggers:
> From: Eric Biggers <ebiggers@google.com>
>
> The primary_crng is always reseeded from the input_pool, while the NUMA
> crngs are always reseeded from the primary_crng. Remove the redundant
> 'use_input_pool' parameter from crng_reseed() and just directly check
> whether the crng is the primary_crng.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
prev parent reply other threads:[~2022-02-05 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 22:17 [PATCH] random: remove use_input_pool parameter from crng_reseed() Eric Biggers
2022-02-04 22:56 ` Jason A. Donenfeld
2022-02-05 7:22 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf4lyqaPOxGoG8/q@owl.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox