Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kyle Sanderson <kyle.leet@gmail.com>,
	Dave Chinner <david@fromorbit.com>,
	qat-linux@intel.com, Linux-Kernal <linux-kernel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs
Date: Wed, 2 Mar 2022 11:49:16 +0000	[thread overview]
Message-ID: <Yh9ZvLHuztwQCu0d@silpixa00400314> (raw)
In-Reply-To: <Yh9G7FyCLtsm2mFA@kroah.com>

Hi Greg,

On Wed, Mar 02, 2022 at 11:29:00AM +0100, Greg KH wrote:
> On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote:
> > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote:
> > > 
> > > It sounds like it was incidental and almost accidental that it fixed
> > > that thing, and nobody realized it should perhaps be also moved to
> > > stable.
> > 
> > Yes this was incidental.  The patch in question fixes an issue in
> > OOM situations where drivers that must allocate memory on each
> > request may lead to dead-lock so it's not really targeted at qat.
> 
> Ok, so what commits should I backport to kernels older than 5.10 to
> resolve this?
Is it possible to wait for a set that resolves the problem rather than
backporting the patches that disables the use-case?
I have a patchset that fixes the actual issue and we are doing an
internal review before submission to the mailing list.
I should be able to send a V1 out between today and tomorrow.

If not, then these are the patches that should be backported:
    7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags
    2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS
    fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY
    b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY
    cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
Herbert, correct me if I'm wrong here.

Thanks,

-- 
Giovanni

  reply	other threads:[~2022-03-02 11:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19  5:02 Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Kyle Sanderson
2022-02-19 21:03 ` Dave Chinner
2022-02-19 23:00   ` Kyle Sanderson
2022-02-21 11:47     ` Giovanni Cabiddu
2022-02-28  8:18       ` Kyle Sanderson
2022-02-28 19:25         ` Linus Torvalds
2022-02-28 20:39           ` Giovanni Cabiddu
2022-02-28 20:59             ` Greg KH
2022-02-28 23:26             ` Herbert Xu
2022-03-01  1:12               ` Linus Torvalds
2022-03-01  4:11                 ` Herbert Xu
2022-03-02 10:29                   ` Greg KH
2022-03-02 11:49                     ` Giovanni Cabiddu [this message]
2022-03-02 14:56                       ` Greg KH
2022-03-02 22:27                         ` Herbert Xu
2022-03-02 22:42                           ` Giovanni Cabiddu
2022-03-02 22:45                             ` Herbert Xu
2022-03-03 13:49                               ` Giovanni Cabiddu
2022-03-03 19:21                                 ` Eric Biggers
2022-03-03 21:24                                   ` Giovanni Cabiddu
2022-03-03 21:44                                     ` Eric Biggers
2022-03-04 17:50                                       ` Giovanni Cabiddu
2022-03-16 21:38                                         ` Kyle Sanderson
2022-03-16 22:13                                           ` Herbert Xu
2022-02-28 21:13           ` [dm-devel] " Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yh9ZvLHuztwQCu0d@silpixa00400314 \
    --to=giovanni.cabiddu@intel.com \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kyle.leet@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox