* [PATCH] crypto: qcom-rng - Fix qcom_rng_of_match unused warning [not found] <202207240830.NxaVYPVM-lkp@intel.com> @ 2022-07-29 9:35 ` Herbert Xu 2022-08-03 12:25 ` Vinod Koul 0 siblings, 1 reply; 2+ messages in thread From: Herbert Xu @ 2022-07-29 9:35 UTC (permalink / raw) To: kernel test robot Cc: Vinod Koul, kbuild-all, linux-kernel, Linus Walleij, Linux Crypto Mailing List On Sun, Jul 24, 2022 at 08:12:39AM +0800, kernel test robot wrote: > > >> drivers/crypto/qcom-rng.c:190:34: warning: 'qcom_rng_of_match' defined but not used [-Wunused-const-variable=] > 190 | static const struct of_device_id qcom_rng_of_match[] = { > | ^~~~~~~~~~~~~~~~~ ---8<--- Module device tables need to be declared as maybe_unused because they will be unused when built-in and the corresponding option is also disabled. This patch adds the maybe_unused attributes to OF and ACPI. This also allows us to remove the ifdef around the ACPI data structure. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c index 031b5f701a0a..72dd1a4ebac4 100644 --- a/drivers/crypto/qcom-rng.c +++ b/drivers/crypto/qcom-rng.c @@ -9,6 +9,7 @@ #include <linux/crypto.h> #include <linux/io.h> #include <linux/iopoll.h> +#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> @@ -201,15 +202,13 @@ static int qcom_rng_remove(struct platform_device *pdev) return 0; } -#if IS_ENABLED(CONFIG_ACPI) -static const struct acpi_device_id qcom_rng_acpi_match[] = { +static const struct acpi_device_id __maybe_unused qcom_rng_acpi_match[] = { { .id = "QCOM8160", .driver_data = 1 }, {} }; MODULE_DEVICE_TABLE(acpi, qcom_rng_acpi_match); -#endif -static const struct of_device_id qcom_rng_of_match[] = { +static const struct of_device_id __maybe_unused qcom_rng_of_match[] = { { .compatible = "qcom,prng", .data = (void *)0}, { .compatible = "qcom,prng-ee", .data = (void *)1}, {} -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: qcom-rng - Fix qcom_rng_of_match unused warning 2022-07-29 9:35 ` [PATCH] crypto: qcom-rng - Fix qcom_rng_of_match unused warning Herbert Xu @ 2022-08-03 12:25 ` Vinod Koul 0 siblings, 0 replies; 2+ messages in thread From: Vinod Koul @ 2022-08-03 12:25 UTC (permalink / raw) To: Herbert Xu Cc: kernel test robot, kbuild-all, linux-kernel, Linus Walleij, Linux Crypto Mailing List On 29-07-22, 17:35, Herbert Xu wrote: > On Sun, Jul 24, 2022 at 08:12:39AM +0800, kernel test robot wrote: > > > > >> drivers/crypto/qcom-rng.c:190:34: warning: 'qcom_rng_of_match' defined but not used [-Wunused-const-variable=] > > 190 | static const struct of_device_id qcom_rng_of_match[] = { > > | ^~~~~~~~~~~~~~~~~ > > ---8<--- > Module device tables need to be declared as maybe_unused because > they will be unused when built-in and the corresponding option is > also disabled. > > This patch adds the maybe_unused attributes to OF and ACPI. This > also allows us to remove the ifdef around the ACPI data structure. Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> > > diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c > index 031b5f701a0a..72dd1a4ebac4 100644 > --- a/drivers/crypto/qcom-rng.c > +++ b/drivers/crypto/qcom-rng.c > @@ -9,6 +9,7 @@ > #include <linux/crypto.h> > #include <linux/io.h> > #include <linux/iopoll.h> > +#include <linux/kernel.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/platform_device.h> > @@ -201,15 +202,13 @@ static int qcom_rng_remove(struct platform_device *pdev) > return 0; > } > > -#if IS_ENABLED(CONFIG_ACPI) > -static const struct acpi_device_id qcom_rng_acpi_match[] = { > +static const struct acpi_device_id __maybe_unused qcom_rng_acpi_match[] = { > { .id = "QCOM8160", .driver_data = 1 }, > {} > }; > MODULE_DEVICE_TABLE(acpi, qcom_rng_acpi_match); > -#endif > > -static const struct of_device_id qcom_rng_of_match[] = { > +static const struct of_device_id __maybe_unused qcom_rng_of_match[] = { > { .compatible = "qcom,prng", .data = (void *)0}, > { .compatible = "qcom,prng-ee", .data = (void *)1}, > {} > -- > Email: Herbert Xu <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- ~Vinod ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-03 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202207240830.NxaVYPVM-lkp@intel.com>
2022-07-29 9:35 ` [PATCH] crypto: qcom-rng - Fix qcom_rng_of_match unused warning Herbert Xu
2022-08-03 12:25 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox