public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Andrew Lutomirski <luto@kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	zhongguohua <zhongguohua1@huawei.com>
Subject: Re: Inquiry about the removal of flag O_NONBLOCK on /dev/random
Date: Wed, 7 Sep 2022 15:03:22 +0200	[thread overview]
Message-ID: <YxiWmiLP11UxyTzs@zx2c4.com> (raw)
In-Reply-To: <CAHmME9qBs0EpBBrragaXFJJ+yKEfBdWGkkZp7T60vq8m8x+RdA@mail.gmail.com>

On Tue, Sep 06, 2022 at 12:16:56PM +0200, Jason A. Donenfeld wrote:
> On Thu, Jul 28, 2022 at 10:25 AM Guozihua (Scott) <guozihua@huawei.com> wrote:
> >
> > On 2022/7/26 19:33, Guozihua (Scott) wrote:
> > > On 2022/7/26 19:08, Jason A. Donenfeld wrote:
> > >> Hi,
> > >>
> > >> On Tue, Jul 26, 2022 at 03:43:31PM +0800, Guozihua (Scott) wrote:
> > >>> Thanks for all the comments on this inquiry. Does the community has any
> > >>> channel to publishes changes like these? And will the man pages get
> > >>> updated? If so, are there any time frame?
> > >>
> > >> I was under the impression you were ultimately okay with the status quo.
> > >> Have I misunderstood you?
> > >>
> > >> Thanks,
> > >> Jason
> > >> .
> > >
> > > Hi Jason.
> > >
> > > To clarify, I does not have any issue with this change. I asked here
> > > only because I would like some background knowledge on this flag, to
> > > ensure I am on the same page as the community regarding this flag and
> > > the change. And it seems that I understands it correctly.
> > >
> > > However I do think it's a good idea to update the document soon to avoid
> > > any misunderstanding in the future.
> > >
> >
> > Our colleague suggests that we should inform users clearly about the
> > change on the flag by returning -EINVAL when /dev/random gets this flag
> > during boot process. Otherwise programs might silently block for a long
> > time, causing other issues. Do you think this is a good way to prevent
> > similar issues on this flag?
> 
> I still don't really understand what you want. First you said this was
> a problem and we should reintroduce the old behavior. Then you said no
> big deal and the docs just needed to be updated. Now you're saying
> this is a problem and we should reintroduce the old behavior?
> 
> I'm just a bit lost on where we were in the conversation.
> 
> Also, could you let me know whether this is affecting real things for
> Huawei, or if this is just something you happened to notice but
> doesn't have any practical impact?

Just following up on this again...

  reply	other threads:[~2022-09-07 13:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  7:33 Inquiry about the removal of flag O_NONBLOCK on /dev/random Guozihua (Scott)
2022-07-18  8:52 ` Guozihua (Scott)
2022-07-19  3:47   ` Eric Biggers
2022-07-19  8:06     ` Guozihua (Scott)
2022-07-19 11:01 ` Jason A. Donenfeld
2022-07-21  3:50   ` Guozihua (Scott)
2022-07-21  4:07     ` Eric Biggers
2022-07-21  6:44       ` Guozihua (Scott)
2022-07-21  6:50         ` Eric Biggers
2022-07-21 10:37           ` Jason A. Donenfeld
2022-07-21 11:30             ` Guozihua (Scott)
2022-07-26  7:43             ` Guozihua (Scott)
2022-07-26 11:08               ` Jason A. Donenfeld
2022-07-26 11:33                 ` Guozihua (Scott)
2022-07-28  8:24                   ` Guozihua (Scott)
2022-09-06  7:14                     ` Guozihua (Scott)
2022-09-06 10:16                     ` Jason A. Donenfeld
2022-09-07 13:03                       ` Jason A. Donenfeld [this message]
2022-09-08  3:31                         ` Guozihua (Scott)
2022-09-08  9:51                           ` Jason A. Donenfeld
2022-09-08 10:40                             ` Jason A. Donenfeld
2022-09-08 14:26                               ` [PATCH] random: restore O_NONBLOCK support Jason A. Donenfeld
2022-09-19 10:27                             ` Inquiry about the removal of flag O_NONBLOCK on /dev/random Guozihua (Scott)
2022-09-19 10:40                               ` Jason A. Donenfeld
2022-09-19 10:45                                 ` Guozihua (Scott)
2022-07-21 11:09         ` Theodore Ts'o
2022-07-21 11:30           ` Guozihua (Scott)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxiWmiLP11UxyTzs@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=ebiggers@kernel.org \
    --cc=guozihua@huawei.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=tytso@mit.edu \
    --cc=zhongguohua1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox