* [PATCH -next] hwrng: Remove duplicated include
@ 2023-08-10 11:58 GUO Zihua
2023-08-10 12:14 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: GUO Zihua @ 2023-08-10 11:58 UTC (permalink / raw)
To: olivia, herbert; +Cc: linux-crypto
Remove duplicated include of linux/random.h. Resolves checkincludes
message.
Signed-off-by: GUO Zihua <guozihua@huawei.com>
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index f34d356fe2c0..ead998ca0c40 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -21,7 +21,6 @@
#include <linux/sched/signal.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
-#include <linux/random.h>
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] hwrng: Remove duplicated include
2023-08-10 11:58 [PATCH -next] hwrng: Remove duplicated include GUO Zihua
@ 2023-08-10 12:14 ` Herbert Xu
2023-08-10 13:02 ` Guozihua (Scott)
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2023-08-10 12:14 UTC (permalink / raw)
To: GUO Zihua; +Cc: olivia, linux-crypto
On Thu, Aug 10, 2023 at 07:58:58PM +0800, GUO Zihua wrote:
> Remove duplicated include of linux/random.h. Resolves checkincludes
> message.
>
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)
Please sort the header files alphabetically.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] hwrng: Remove duplicated include
2023-08-10 12:14 ` Herbert Xu
@ 2023-08-10 13:02 ` Guozihua (Scott)
0 siblings, 0 replies; 3+ messages in thread
From: Guozihua (Scott) @ 2023-08-10 13:02 UTC (permalink / raw)
To: Herbert Xu; +Cc: olivia, linux-crypto
On 2023/8/10 20:14, Herbert Xu wrote:
> On Thu, Aug 10, 2023 at 07:58:58PM +0800, GUO Zihua wrote:
>> Remove duplicated include of linux/random.h. Resolves checkincludes
>> message.
>>
>> Signed-off-by: GUO Zihua <guozihua@huawei.com>
>> ---
>> drivers/char/hw_random/core.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Please sort the header files alphabetically.
>
> Thanks,
Hi Herbert,
Thanks for the incredibly timely reply! A v2 has been sent.
--
Best
GUO Zihua
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-10 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 11:58 [PATCH -next] hwrng: Remove duplicated include GUO Zihua
2023-08-10 12:14 ` Herbert Xu
2023-08-10 13:02 ` Guozihua (Scott)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox