From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
qat-linux@intel.com, alx@kernel.org,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v2 1/2] crypto: qat - refactor included headers
Date: Tue, 29 Aug 2023 18:18:24 +0800 [thread overview]
Message-ID: <ZO3F8AgOS/NnVaeU@gondor.apana.org.au> (raw)
In-Reply-To: <ZOx6+i5HEAY4F4X3@smile.fi.intel.com>
On Mon, Aug 28, 2023 at 01:46:18PM +0300, Andy Shevchenko wrote:
>
> kernel.h is misleading here. It includes 98% of something which this file is
> not using or going to use. Can you tell _why_ we need that 98% bulk to be
> included here?
For most drivers in drivers/crypto they will need multiple header
files included by kernel.h. I'd hate for people to start posting
patches replacing one inclusion of kernel.h with multiple inclusions.
They're bound to get it wrong and we'll be forever dealing with
random build failures because someone changes a random header
elsewhere which then exposes a missed inclusion.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-08-29 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 10:23 [PATCH v2 0/2] Add debugfs pm_status for qat driver Lucas Segarra Fernandez
2023-08-18 10:23 ` [PATCH v2 1/2] crypto: qat - refactor included headers Lucas Segarra Fernandez
2023-08-25 10:36 ` Herbert Xu
2023-08-25 10:41 ` Herbert Xu
2023-08-25 11:00 ` Herbert Xu
2023-08-25 12:37 ` Andy Shevchenko
2023-08-28 10:22 ` Herbert Xu
2023-08-28 10:46 ` Andy Shevchenko
2023-08-29 10:18 ` Herbert Xu [this message]
2023-08-29 14:08 ` Andy Shevchenko
2023-08-31 3:55 ` Herbert Xu
2023-08-31 11:18 ` Alejandro Colomar
2023-08-31 13:29 ` Andy Shevchenko
2023-08-31 13:26 ` Andy Shevchenko
2023-08-18 10:23 ` [PATCH v2 2/2] crypto: qat - add pm_status debugfs file Lucas Segarra Fernandez
2023-08-25 10:39 ` Herbert Xu
2023-08-25 12:38 ` Andy Shevchenko
2023-08-25 11:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3F8AgOS/NnVaeU@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alx@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.segarra.fernandez@intel.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox