* [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
@ 2025-05-08 6:26 Dan Carpenter
2025-05-08 8:18 ` Cabiddu, Giovanni
2025-05-14 9:50 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-05-08 6:26 UTC (permalink / raw)
To: Laurent M Coquerel
Cc: Giovanni Cabiddu, Herbert Xu, David S. Miller, George Abraham P,
Suman Kumar Chakraborty, Karthikeyan Gopal, qat-linux,
linux-crypto, linux-kernel, kernel-janitors
The pcim_iomap_region() returns error pointers. It doesn't return NULL
pointers. Update the check to match.
Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
index 2531c337e0dd..132e26501621 100644
--- a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
+++ b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c
@@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Map 64-bit PCIe BAR */
bar->virt_addr = pcim_iomap_region(pdev, bar_map[i], pci_name(pdev));
- if (!bar->virt_addr) {
- ret = -ENOMEM;
+ if (IS_ERR(bar->virt_addr)) {
+ ret = PTR_ERR(bar->virt_addr);
return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n");
}
}
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
2025-05-08 6:26 [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe() Dan Carpenter
@ 2025-05-08 8:18 ` Cabiddu, Giovanni
2025-05-14 9:50 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Cabiddu, Giovanni @ 2025-05-08 8:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent M Coquerel, Herbert Xu, David S. Miller, George Abraham P,
Suman Kumar Chakraborty, Karthikeyan Gopal, qat-linux,
linux-crypto, linux-kernel, kernel-janitors
Thanks Dan.
On Thu, May 08, 2025 at 09:26:25AM +0300, Dan Carpenter wrote:
> The pcim_iomap_region() returns error pointers. It doesn't return NULL
> pointers. Update the check to match.
>
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
2025-05-08 6:26 [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe() Dan Carpenter
2025-05-08 8:18 ` Cabiddu, Giovanni
@ 2025-05-14 9:50 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2025-05-14 9:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent M Coquerel, Giovanni Cabiddu, David S. Miller,
George Abraham P, Suman Kumar Chakraborty, Karthikeyan Gopal,
qat-linux, linux-crypto, linux-kernel, kernel-janitors
On Thu, May 08, 2025 at 09:26:25AM +0300, Dan Carpenter wrote:
> The pcim_iomap_region() returns error pointers. It doesn't return NULL
> pointers. Update the check to match.
>
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-14 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 6:26 [PATCH next] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe() Dan Carpenter
2025-05-08 8:18 ` Cabiddu, Giovanni
2025-05-14 9:50 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox