From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Karthikeyan Gopal <karthikeyan.gopal@intel.com>,
Laurent M Coquerel <laurent.m.coquerel@intel.com>,
Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
George Abraham P <george.abraham.p@intel.com>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: qat - add missing header inclusion
Date: Fri, 23 May 2025 19:27:32 +0800 [thread overview]
Message-ID: <aDBbpOtpr5ATk4Rj@gondor.apana.org.au> (raw)
In-Reply-To: <aC76tZFMTee1hHI3@gcabiddu-mobl.ger.corp.intel.com>
On Thu, May 22, 2025 at 11:21:41AM +0100, Cabiddu, Giovanni wrote:
>
> Without this header, the build of the new qat_6xxx driver fails when
> CONFIG_PCI_IOV is not set:
>
> In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
> 13 | pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
> drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
> 2 files changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-05-23 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 16:11 [PATCH] crypto: qat - add missing header inclusion Arnd Bergmann
2025-05-21 4:56 ` Cabiddu, Giovanni
2025-05-22 10:21 ` [PATCH v2] " Cabiddu, Giovanni
2025-05-23 11:27 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDBbpOtpr5ATk4Rj@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=george.abraham.p@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=karthikeyan.gopal@intel.com \
--cc=laurent.m.coquerel@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=suman.kumar.chakraborty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox